[jira] [Commented] (KAFKA-6788) Grouping consumer requests per consumer coordinator in admin client

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-6788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16438957#comment-16438957 ] 

ASF GitHub Bot commented on KAFKA-6788:
---------------------------------------

cyrusv opened a new pull request #4875: KAFKA-6788: Grouping consumer requests per consumer coordinator in admin client
URL: https://github.com/apache/kafka/pull/4875
 
 
   Resolves KAFKA-6788 for the deleteGroup case
   
   For the "describeGroup" case, we build a hash-set and `continue` when we have already described the group. The describe API lets us submit all groups so this is the only work we must do.
   
   For the "deleteGroup" case, we ask the Coordinator which groups it knows about, and delete those. Also use a hashset to `continue` over groups we have already deleted.
   
   Passes tests, no new testing or documentation necessary.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Grouping consumer requests per consumer coordinator in admin client
> -------------------------------------------------------------------
>
>                 Key: KAFKA-6788
>                 URL: https://issues.apache.org/jira/browse/KAFKA-6788
>             Project: Kafka
>          Issue Type: Improvement
>          Components: admin
>            Reporter: Guozhang Wang
>            Priority: Major
>              Labels: newbie++
>
> In KafkaAdminClient, for some requests like describeGroup and deleteGroup, we will first try to get the coordinator for each requested group id, and then send the corresponding request for that group id. However, different group ids could be hosted on the same coordinator, and these requests do support multi group ids be sent within the same request. So we can consider optimize it by grouping the requests per coordinator destination.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)