You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/11/03 13:49:22 UTC

[GitHub] [rocketmq-flink] deemogsw opened a new pull request, #72: [ISSUE #63]

deemogsw opened a new pull request, #72:
URL: https://github.com/apache/rocketmq-flink/pull/72

   Support rich initialization modes of RocketMQSource Fix some bugs


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-flink] GOODBOY008 commented on pull request #72: [ISSUE #63] Support rich initialization modes of RocketMQSource & Fix some bugs

Posted by GitBox <gi...@apache.org>.
GOODBOY008 commented on PR #72:
URL: https://github.com/apache/rocketmq-flink/pull/72#issuecomment-1308065051

   @deemogsw Thanks for your contributions! Can you rebase to last main branch. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-flink] SteNicholas commented on pull request #72: [ISSUE #63] Support rich initialization modes of RocketMQSource & Fix some bugs

Posted by GitBox <gi...@apache.org>.
SteNicholas commented on PR #72:
URL: https://github.com/apache/rocketmq-flink/pull/72#issuecomment-1313408385

   @deemogsw, could you please resolve the conflicts firstly?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-flink] deemogsw commented on pull request #72: [ISSUE #63] Support rich initialization modes of RocketMQSource & Fix some bugs

Posted by GitBox <gi...@apache.org>.
deemogsw commented on PR #72:
URL: https://github.com/apache/rocketmq-flink/pull/72#issuecomment-1302148512

   - [x] [bug]PartitionDiscoveryIntervalMs can't set to negative 
   - [x] [bug]Idle source task can't be released automatic  
   - [x] [bug]Offset didn't commit to broker in `RockerMQSource` in phase of checkpoint
   - [x] [bug]Records can't arrive to sink() in UNBOUNDESS mode  
   - [ ] [features]Commit offset immediately when checkpoint is disable     --- is necessary?
   - [x] [features]Metrics with new source    
   - [x] [features]Boost for flink-sql-connector


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-flink] deemogsw commented on pull request #72: [ISSUE #63] Support rich initialization modes of RocketMQSource & Fix some bugs

Posted by GitBox <gi...@apache.org>.
deemogsw commented on PR #72:
URL: https://github.com/apache/rocketmq-flink/pull/72#issuecomment-1302166031

   As description in issue #69 ,branch of master has some bugs with pr #46 .So my branch still be dependent on common pull mode.
   I will complete the README.md with usage of sql-connector later.
   @lizhimins @SteNicholas Can you help me review the code?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-flink] deemogsw commented on pull request #72: [ISSUE #63] Support rich initialization modes of RocketMQSource & Fix some bugs

Posted by GitBox <gi...@apache.org>.
deemogsw commented on PR #72:
URL: https://github.com/apache/rocketmq-flink/pull/72#issuecomment-1308457322

   > @deemogsw Thanks for your contributions! Can you rebase to last main branch.
   
   Main branch has bug in litepull consumer.I have mentioned in issue #69 .You can also have a try by running the latest cade


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org