You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/04/29 11:32:43 UTC

[GitHub] [airflow] JorgenG commented on a diff in pull request #23357: Allow back script_location in Glue to be None

JorgenG commented on code in PR #23357:
URL: https://github.com/apache/airflow/pull/23357#discussion_r861719127


##########
airflow/providers/amazon/aws/operators/glue.py:
##########
@@ -104,7 +104,9 @@ def execute(self, context: 'Context'):
 
         :return: the id of the current glue job.
         """
-        if not self.script_location.startswith(self.s3_protocol):
+        if self.script_location is None:
+            s3_script_location = None
+        elif self.script_location.startswith(self.s3_protocol):

Review Comment:
   ```suggestion
           elif not self.script_location.startswith(self.s3_protocol):
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org