You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/05/27 06:15:33 UTC
[GitHub] [cloudstack-primate] utchoang opened a new pull request #364: Add boottype and bootmode to VM instance
utchoang opened a new pull request #364:
URL: https://github.com/apache/cloudstack-primate/pull/364
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd merged pull request #364: Add boottype and bootmode to VM instance
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #364:
URL: https://github.com/apache/cloudstack-primate/pull/364
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #364: Add boottype and bootmode to VM instance
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #364:
URL: https://github.com/apache/cloudstack-primate/pull/364#discussion_r434403478
##########
File path: src/views/compute/DeployVM.vue
##########
@@ -80,6 +80,29 @@
:options="keyboardSelectOptions"
></a-select>
</a-form-item>
+ <a-form-item
Review comment:
@utchoang cc @DaanHoogland - the hypervisor would probably only be available once (a) the template is selected or (b) ISO is selected and hypervisor is selected; should this be moved after the template section then?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] DaanHoogland commented on a change in pull request #364: Add boottype and bootmode to VM instance
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #364:
URL: https://github.com/apache/cloudstack-primate/pull/364#discussion_r431611737
##########
File path: src/views/compute/DeployVM.vue
##########
@@ -80,6 +80,25 @@
:options="keyboardSelectOptions"
></a-select>
</a-form-item>
+ <a-form-item :label="this.$t('label.vm.boottype')">
+ <a-select
+ v-decorator="['boottype']"
+ @change="fetchBootModes"
+ >
+ <a-select-option v-for="bootType in options.bootTypes" :key="bootType.id">
+ {{ bootType.description }}
+ </a-select-option>
+ </a-select>
+ </a-form-item>
+ <a-form-item :label="this.$t('label.vm.bootmode')">
+ <a-select
+ v-decorator="['bootmode']"
+ >
+ <a-select-option v-for="bootMode in options.bootModes" :key="bootMode.id">
+ {{ bootMode.description }}
+ </a-select-option>
+ </a-select>
+ </a-form-item>
Review comment:
@utchoang I think that is an oversight or short cut in the new UI. The UI is being phased out and the feature rather new. I think it slipped attention.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on a change in pull request #364: Add boottype and bootmode to VM instance
Posted by GitBox <gi...@apache.org>.
utchoang commented on a change in pull request #364:
URL: https://github.com/apache/cloudstack-primate/pull/364#discussion_r434958855
##########
File path: src/views/compute/DeployVM.vue
##########
@@ -80,6 +80,29 @@
:options="keyboardSelectOptions"
></a-select>
</a-form-item>
+ <a-form-item
Review comment:
@rhtyd I moved it below the template/iso section
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #364: Add boottype and bootmode to VM instance
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #364:
URL: https://github.com/apache/cloudstack-primate/pull/364#issuecomment-639268240
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/364 (JID-1969)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] DaanHoogland commented on a change in pull request #364: Add boottype and bootmode to VM instance
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #364:
URL: https://github.com/apache/cloudstack-primate/pull/364#discussion_r431012633
##########
File path: src/views/compute/DeployVM.vue
##########
@@ -80,6 +80,25 @@
:options="keyboardSelectOptions"
></a-select>
</a-form-item>
+ <a-form-item :label="this.$t('label.vm.boottype')">
+ <a-select
+ v-decorator="['boottype']"
+ @change="fetchBootModes"
+ >
+ <a-select-option v-for="bootType in options.bootTypes" :key="bootType.id">
+ {{ bootType.description }}
+ </a-select-option>
+ </a-select>
+ </a-form-item>
+ <a-form-item :label="this.$t('label.vm.bootmode')">
+ <a-select
+ v-decorator="['bootmode']"
+ >
+ <a-select-option v-for="bootMode in options.bootModes" :key="bootMode.id">
+ {{ bootMode.description }}
+ </a-select-option>
+ </a-select>
+ </a-form-item>
Review comment:
This needs to be for vmware and kvm only i think
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #364: Add boottype and bootmode to VM instance
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #364:
URL: https://github.com/apache/cloudstack-primate/pull/364#issuecomment-645283771
Headsup @utchoang - I've moved the name/details to the end step because of dependencies from later steps
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #364: Add boottype and bootmode to VM instance
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #364:
URL: https://github.com/apache/cloudstack-primate/pull/364#issuecomment-639262739
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #364: Add boottype and bootmode to VM instance
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #364:
URL: https://github.com/apache/cloudstack-primate/pull/364#issuecomment-639262988
@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on a change in pull request #364: Add boottype and bootmode to VM instance
Posted by GitBox <gi...@apache.org>.
utchoang commented on a change in pull request #364:
URL: https://github.com/apache/cloudstack-primate/pull/364#discussion_r431549452
##########
File path: src/views/compute/DeployVM.vue
##########
@@ -80,6 +80,25 @@
:options="keyboardSelectOptions"
></a-select>
</a-form-item>
+ <a-form-item :label="this.$t('label.vm.boottype')">
+ <a-select
+ v-decorator="['boottype']"
+ @change="fetchBootModes"
+ >
+ <a-select-option v-for="bootType in options.bootTypes" :key="bootType.id">
+ {{ bootType.description }}
+ </a-select-option>
+ </a-select>
+ </a-form-item>
+ <a-form-item :label="this.$t('label.vm.bootmode')">
+ <a-select
+ v-decorator="['bootmode']"
+ >
+ <a-select-option v-for="bootMode in options.bootModes" :key="bootMode.id">
+ {{ bootMode.description }}
+ </a-select-option>
+ </a-select>
+ </a-form-item>
Review comment:
@rhtyd Do you think about this? Because on https://github.com/apache/cloudstack/blob/d4b537efa7ed27ef88b735a22493808b61529186/ui/scripts/ui-custom/instanceWizard.js. I don't see any description for show/hidden of boot type & bootmode
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org