[GitHub] [spark] dongjoon-hyun commented on a change in pull request #31793: [SPARK-34682] [SQL] Fix regression in canonicalization error check in CustomShuffleReaderExec

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #31793:
URL: https://github.com/apache/spark/pull/31793#discussion_r590920792



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/CustomShuffleReaderExec.scala
##########
@@ -179,12 +179,12 @@ case class CustomShuffleReaderExec private(
   }
 
   private lazy val shuffleRDD: RDD[_] = {
-    sendDriverMetrics()

Review comment:
       So, this is a regression from SPARK-31253 (https://github.com/apache/spark/commit/d136b7248ecc7303f86da8f68e0625d9d0725a50)? Do you think we can have a test case for `NoSuchElementException`?
   ```scala
   - val executionId = sparkContext.getLocalProperty(SQLExecution.EXECUTION_ID_KEY)
   - SQLMetrics.postDriverMetricUpdates(sparkContext, executionId, metrics.values.toSeq)
   + sendDriverMetrics()
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org