You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/12/16 14:40:03 UTC
[GitHub] [cordova-lib] raphinesse opened a new pull request #864: test(pkgJson): fix test after release of geolocation plugin v4.1.0
raphinesse opened a new pull request #864:
URL: https://github.com/apache/cordova-lib/pull/864
When `cordova-plugin-geolocation` introduced a new variable in v4.1.0, a test that expected it to have no variables started failing.
However, if there were variables or not was beside the point of the test in the first place. It should only check that the key for the plugin is present in `cordova.plugins`.
I updated the test accordingly.
Fixes #863
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-lib] raphinesse merged pull request #864: test(pkgJson): fix test after release of geolocation plugin v4.1.0
Posted by GitBox <gi...@apache.org>.
raphinesse merged pull request #864:
URL: https://github.com/apache/cordova-lib/pull/864
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org