You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yyqdbngt (via GitHub)" <gi...@apache.org> on 2026/09/05 15:59:06 UTC
[PR] test: cover blank, non-numeric and overflow cases in EntityIds [rocketmq-dashboard]
yyqdbngt opened a new pull request, #3442:
URL: https://github.com/apache/rocketmq-dashboard/pull/3442
### Summary
`EntityIds.parseId` converts external string ids to positive database primary keys with uniform 400 errors. The suite covered trimmed parsing and zero/negative rejection only.
### Changes
- `null` and blank ids fail with `400 id is required`
- Non-numeric values (pure or trailing garbage) fail with `id must be a numeric value`
- Positive ids parse across the full `long` range, while an overflowing value is rejected instead of wrapping
### Testing
`mvn test -Dtest=EntityIdsTest` passes: 5 tests, 0 failures (up from 2).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test: cover blank, non-numeric and overflow cases in EntityIds [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #3442: test: cover blank, non-numeric and overflow cases in EntityIds
URL: https://github.com/apache/rocketmq-dashboard/pull/3442
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org