[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #356: [FLINK-29100] Relax upgrade checks to allow stateless restart when no stable spec is present

[GitBox <gi...@apache.org>]

gyfora commented on code in PR #356:
URL: https://github.com/apache/flink-kubernetes-operator/pull/356#discussion_r956971013


##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/AbstractJobReconciler.java:
##########
@@ -107,12 +107,18 @@ protected void reconcileSpecChange(
 
         JobState currentJobState = lastReconciledSpec.getJob().getState();
         JobState desiredJobState = currentDeploySpec.getJob().getState();
+        // check upgrade mode compatibility if deployment was ever stable
+        // an initially unsuccessful deployment can be reverted
+        var hasStableSpec =
+                resource.getStatus().getReconciliationStatus().getLastStableSpec() != null;

Review Comment:
   I think this check is too weak. You might have completed checkpoints already at this point (if the job went into a restart loop after some checkpoints but before the operator considered it to be stable).
   
   Also as we improve stability conditions it might become even weaker in the future



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org