You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/08/01 11:16:30 UTC

[GitHub] [airflow] ashb opened a new pull request, #25441: Fix `airflow db reset` when dangling tables exist

ashb opened a new pull request, #25441:
URL: https://github.com/apache/airflow/pull/25441

   If one of the "dangling" tables already existed in the DB, performing an `airflow db reset` would delete the tables, but it would then try and _re-create_ the table later. This was because the Table object was still associated with the Metadata object.
   
   The fix is to remove the it from Metadata once we have dropped it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] ashb commented on pull request #25441: Fix `airflow db reset` when dangling tables exist

Posted by GitBox <gi...@apache.org>.
ashb commented on PR #25441:
URL: https://github.com/apache/airflow/pull/25441#issuecomment-1201072201

   > I think it would be safer to use checkfirst=True?
   
   Two lines up we got the table name from doing `inspect.get_table_names()` -- we've done the check ourselves already.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] ephraimbuddy merged pull request #25441: Fix `airflow db reset` when dangling tables exist

Posted by GitBox <gi...@apache.org>.
ephraimbuddy merged PR #25441:
URL: https://github.com/apache/airflow/pull/25441


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org