You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/10/11 07:41:00 UTC
[jira] [Commented] (MWRAPPER-80) Support maven-mvnd as a maven distribution
[ https://issues.apache.org/jira/browse/MWRAPPER-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17615556#comment-17615556 ]
ASF GitHub Bot commented on MWRAPPER-80:
----------------------------------------
gzm55 opened a new pull request, #65:
URL: https://github.com/apache/maven-wrapper/pull/65
Try to integrate maven-mvnd as a maven distribution. Now `only-mvnw` works fine without sha256 checksum verification.
- manual select platform: distributionUrl=https://downloads.apache.org/maven/mvnd/0.8.2/maven-mvnd-0.8.2-darwin-amd64.zip
- auto select platform: distributionUrl=https://downloads.apache.org/maven/mvnd/0.8.2/maven-mvnd-0.8.2-bin.zip
In the auto mode, the script selects a proper platform via the result of "uname -a", or fallback to the pure java version for unknown platform. For `distributionSha256Sum`, we also need new pattern to support multiple checksums, such as `distributionSha256Sum=darwin-aarch64:111;linux-amd64:222`
Following this checklist to help us incorporate your
contribution quickly and easily:
- [X] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MWRAPPER) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [X] Each commit in the pull request should have a meaningful subject line and body.
- [X] Format the pull request title like `[MWRAPPER-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `MWRAPPER-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [X] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [X] You have run the integration tests successfully (`mvn -Prun-its clean verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [X] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [X] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
> Support maven-mvnd as a maven distribution
> ------------------------------------------
>
> Key: MWRAPPER-80
> URL: https://issues.apache.org/jira/browse/MWRAPPER-80
> Project: Maven Wrapper
> Issue Type: New Feature
> Components: Maven Wrapper Scripts
> Reporter: James Z.M. Gao
> Priority: Major
>
> Here is a proposal method to integrate maven-mvnd.
> When set distributionUrl to a maven-mvnd downloading url, the wrapper should distinguish then download/install/run the maven-mvnd on the fly. The script should take own the os/hardware detecting to select a proper native version. For example:
> * manual select platform: distributionUrl=[https://downloads.apache.org/maven/mvnd/0.8.2/maven-mvnd-0.8.2-darwin-amd64.zip]
> * auto select platform: distributionUrl=[https://downloads.apache.org/maven/mvnd/0.8.2/maven-mvnd-0.8.2-bin.zip]
> In the auto mode, the script can select the real platform via the result of "uname -a", or fallback to the pure java version for unknown platform. For `distributionSha256Sum`, we also need new pattern to support multiple checksum, such as
>
> * distributionSha256Sum=darwin-aarch64:111;linux-amd64:222
--
This message was sent by Atlassian Jira
(v8.20.10#820010)