[jira] Issue Comment Edited: (THRIFT-83) The Erlang http transport sends an empty request when closed

["Todd Lipcon (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12613516#action_12613516 ] 

tlipcon edited comment on THRIFT-83 at 7/14/08 8:20 PM:
------------------------------------------------------------

Looks good to me.

Only thing is that it might be clearer to do this as a second function clause written before the original function clause. It's just a matter of style, but I tend to prefer multiple clauses over a function that has only a single case in its body.

EDIT: dreiss pointed out that write_buffer is an iolist, not a binary, so ignore the above.

      was (Author: tlipcon):
    Looks good to me.

Only thing is that it might be clearer to do this as a second function clause written before the original function clause. It's just a matter of style, but I tend to prefer multiple clauses over a function that has only a single case in its body.
  
> The Erlang http transport sends an empty request when closed
> ------------------------------------------------------------
>
>                 Key: THRIFT-83
>                 URL: https://issues.apache.org/jira/browse/THRIFT-83
>             Project: Thrift
>          Issue Type: Bug
>          Components: Library (Erlang)
>            Reporter: David Reiss
>            Assignee: David Reiss
>            Priority: Minor
>
> http://gitweb.thrift-rpc.org/?p=thrift.git;a=commitdiff;h=refs/heads/pri/dreiss/erl_http

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.