You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "techdocsmith (via GitHub)" <gi...@apache.org> on 2023/04/04 23:31:38 UTC

[GitHub] [druid] techdocsmith opened a new pull request, #14026: Fix querying sql

techdocsmith opened a new pull request, #14026:
URL: https://github.com/apache/druid/pull/14026

   Updates the querying tutorial to match the data set used in the current local quickstart.
   Removes the `dsql` instructions because it appears to be broken. See: 
   
   
   This PR has:
   
   - [x ] been self-reviewed.
   - [x ] been tested in a test Druid cluster.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


[GitHub] [druid] vtlim commented on a diff in pull request #14026: Fix querying sql

Posted by "vtlim (via GitHub)" <gi...@apache.org>.
vtlim commented on code in PR #14026:
URL: https://github.com/apache/druid/pull/14026#discussion_r1159148060


##########
docs/tutorials/tutorial-query.md:
##########
@@ -144,18 +144,19 @@ performance issues. For more information, see [Native queries](../querying/query
 9. Finally, click  `...`  and **Edit context** to see how you can add additional parameters controlling the execution of the query execution. In the field, enter query context options as JSON key-value pairs, as described in [Context flags](../querying/query-context.md).  
 
 That's it! We've built a simple query using some of the query builder features built into the web console. The following
-sections provide a few more example queries you can try. Also, see [Other ways to invoke SQL queries](#other-ways-to-invoke-sql-queries) to learn how
-to run Druid SQL from the command line or over HTTP. 
+sections provide a few more example queries you can try.
+
+See [Query SQL over HTTP](#query-sql-over-http) for an example of how to use the Druid SQL HTTP API. 
 
 ## More Druid SQL examples
 
-Here is a collection of queries to try out:
+Try the following queries to learn a few more Duid SQL tricks:

Review Comment:
   ```suggestion
   Try the following queries to learn a few more Druid SQL tricks:
   ```



##########
docs/tutorials/tutorial-query.md:
##########
@@ -165,58 +166,21 @@ GROUP BY 1
 
 ```sql
 SELECT channel, page, SUM(added)
-FROM wikipedia WHERE TIME_IN_INTERVAL("__time", '2015-09-12/2015-09-13')
+FROM wikipedia WHERE TIME_IN_INTERVAL("__time", '2016-06-27/2016-06-28')
 GROUP BY channel, page
 ORDER BY SUM(added) DESC
 ```
 
 ![Query example](../assets/tutorial-query-07.png "Query example")
 
-
-## Other ways to invoke SQL queries
-
-### Query SQL via dsql
-
-For convenience, the Druid package includes a SQL command-line client, located at `bin/dsql` in the Druid package root.
-
-Let's now run `bin/dsql`; you should see the following prompt:
-
-```bash
-Welcome to dsql, the command-line client for Druid SQL.
-Type "\h" for help.
-dsql>
-```
-
-To submit the query, paste it to the `dsql` prompt and press enter:
-
-```bash
-dsql> SELECT page, COUNT(*) AS Edits FROM wikipedia WHERE TIME_IN_INTERVAL("__time", '2015-09-12/2015-09-13') GROUP BY page ORDER BY Edits DESC LIMIT 10;
-┌──────────────────────────────────────────────────────────┬───────┐
-│ page                                                     │ Edits │
-├──────────────────────────────────────────────────────────┼───────┤
-│ Wikipedia:Vandalismusmeldung                             │    33 │
-│ User:Cyde/List of candidates for speedy deletion/Subpage │    28 │
-│ Jeremy Corbyn                                            │    27 │
-│ Wikipedia:Administrators' noticeboard/Incidents          │    21 │
-│ Flavia Pennetta                                          │    20 │
-│ Total Drama Presents: The Ridonculous Race               │    18 │
-│ User talk:Dudeperson176123                               │    18 │
-│ Wikipédia:Le Bistro/12 septembre 2015                    │    18 │
-│ Wikipedia:In the news/Candidates                         │    17 │
-│ Wikipedia:Requests for page protection                   │    17 │
-└──────────────────────────────────────────────────────────┴───────┘
-Retrieved 10 rows in 0.06s.
-```
-
-
-### Query SQL over HTTP
+## Query SQL over HTTP
 
 
-You can submit native queries [directly to the Druid Broker over HTTP](../querying/sql-api.md#submit-a-query). The request body should be a JSON object, with the value for the key `query` containing text of the query:
+You can submit native queries [over HTTP](../querying/sql-api.md#submit-a-query). The request body should be a JSON object, with the value for the key `query` containing text of the query:

Review Comment:
   ```suggestion
   You can submit native queries [over HTTP](../querying/sql-api.md#submit-a-query). The request body is a JSON object in which the `query` field contains the text of the query:
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


[GitHub] [druid] vtlim merged pull request #14026: Fix querying sql

Posted by "vtlim (via GitHub)" <gi...@apache.org>.
vtlim merged PR #14026:
URL: https://github.com/apache/druid/pull/14026


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org