You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Rustem Rafikov (JIRA)" <ji...@apache.org> on 2007/10/09 17:41:50 UTC
[jira] Created: (HARMONY-4914) [drlvm] increasing default sizes
for code and vtable pools give a little boost
[drlvm] increasing default sizes for code and vtable pools give a little boost
-------------------------------------------------------------------------------
Key: HARMONY-4914
URL: https://issues.apache.org/jira/browse/HARMONY-4914
Project: Harmony
Issue Type: Improvement
Components: DRLVM
Environment: windows, linux
Reporter: Rustem Rafikov
Priority: Minor
Attachments: code-size.patch
I suggest to increase the default sizes for vtable and code pools (see vm/vmcore/include/mem_alloc.h).
It reduces fragmentation of data and thus gives a little boost on specjbb2005 (as example).
For example, the default code pool size for bootstrap classloader is 256K. Final size is about 2Mb, so it is reallocated ~6-7 times. The numbers for default classloader are: 64K - default, ~800K - final, it is realocated 11-12 times.
The patch is attached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-4914) [drlvm] increasing default sizes
for code and vtable pools give a little boost
Posted by "Alexey Varlamov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12534220 ]
Alexey Varlamov commented on HARMONY-4914:
------------------------------------------
Hmm, this would increase minimal footprint for ~9Mb. How much boost it gives?
BTW, currently pools grow linearly; so more sophisticated approach would be making the reallocation size adaptive.
Also, fragmentation can be reduced via use of virtual memory allocation (vs current malloc): reserve bigger arenas but commit with smaller chunks as needed.
> [drlvm] increasing default sizes for code and vtable pools give a little boost
> -------------------------------------------------------------------------------
>
> Key: HARMONY-4914
> URL: https://issues.apache.org/jira/browse/HARMONY-4914
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Environment: windows, linux
> Reporter: Rustem Rafikov
> Priority: Minor
> Attachments: code-size.patch
>
>
> I suggest to increase the default sizes for vtable and code pools (see vm/vmcore/include/mem_alloc.h).
> It reduces fragmentation of data and thus gives a little boost on specjbb2005 (as example).
> For example, the default code pool size for bootstrap classloader is 256K. Final size is about 2Mb, so it is reallocated ~6-7 times. The numbers for default classloader are: 64K - default, ~800K - final, it is realocated 11-12 times.
> The patch is attached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HARMONY-4914) [drlvm] increasing default sizes
for code and vtable pools give a little boost
Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Shimansky resolved HARMONY-4914.
----------------------------------------
Resolution: Fixed
Patch is applied at 598969. Please check that performance is ok.
> [drlvm] increasing default sizes for code and vtable pools give a little boost
> -------------------------------------------------------------------------------
>
> Key: HARMONY-4914
> URL: https://issues.apache.org/jira/browse/HARMONY-4914
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Environment: windows, linux
> Reporter: Rustem Rafikov
> Assignee: Gregory Shimansky
> Priority: Minor
> Attachments: code-size.patch, code-size.patch
>
>
> I suggest to increase the default sizes for vtable and code pools (see vm/vmcore/include/mem_alloc.h).
> It reduces fragmentation of data and thus gives a little boost on specjbb2005 (as example).
> For example, the default code pool size for bootstrap classloader is 256K. Final size is about 2Mb, so it is reallocated ~6-7 times. The numbers for default classloader are: 64K - default, ~800K - final, it is realocated 11-12 times.
> The patch is attached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (HARMONY-4914) [drlvm] increasing default sizes for
code and vtable pools give a little boost
Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Shimansky closed HARMONY-4914.
--------------------------------------
No response, assuming ok.
> [drlvm] increasing default sizes for code and vtable pools give a little boost
> -------------------------------------------------------------------------------
>
> Key: HARMONY-4914
> URL: https://issues.apache.org/jira/browse/HARMONY-4914
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Environment: windows, linux
> Reporter: Rustem Rafikov
> Assignee: Gregory Shimansky
> Priority: Minor
> Attachments: code-size.patch, code-size.patch
>
>
> I suggest to increase the default sizes for vtable and code pools (see vm/vmcore/include/mem_alloc.h).
> It reduces fragmentation of data and thus gives a little boost on specjbb2005 (as example).
> For example, the default code pool size for bootstrap classloader is 256K. Final size is about 2Mb, so it is reallocated ~6-7 times. The numbers for default classloader are: 64K - default, ~800K - final, it is realocated 11-12 times.
> The patch is attached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-4914) [drlvm] increasing default sizes
for code and vtable pools give a little boost
Posted by "Rustem Rafikov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rustem Rafikov updated HARMONY-4914:
------------------------------------
Attachment: code-size.patch
> [drlvm] increasing default sizes for code and vtable pools give a little boost
> -------------------------------------------------------------------------------
>
> Key: HARMONY-4914
> URL: https://issues.apache.org/jira/browse/HARMONY-4914
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Environment: windows, linux
> Reporter: Rustem Rafikov
> Priority: Minor
> Attachments: code-size.patch
>
>
> I suggest to increase the default sizes for vtable and code pools (see vm/vmcore/include/mem_alloc.h).
> It reduces fragmentation of data and thus gives a little boost on specjbb2005 (as example).
> For example, the default code pool size for bootstrap classloader is 256K. Final size is about 2Mb, so it is reallocated ~6-7 times. The numbers for default classloader are: 64K - default, ~800K - final, it is realocated 11-12 times.
> The patch is attached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-4914) [drlvm] increasing default sizes
for code and vtable pools give a little boost
Posted by "Vladimir Beliaev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12534806 ]
Vladimir Beliaev commented on HARMONY-4914:
-------------------------------------------
My concern is that such changes should be carefully tested (not only with the help of acceptance tests). They looks simple, still I'm not sure there is no related restrictions hardcoded somewhere in VM code which would conflict with the proposed increasing.
> [drlvm] increasing default sizes for code and vtable pools give a little boost
> -------------------------------------------------------------------------------
>
> Key: HARMONY-4914
> URL: https://issues.apache.org/jira/browse/HARMONY-4914
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Environment: windows, linux
> Reporter: Rustem Rafikov
> Priority: Minor
> Attachments: code-size.patch
>
>
> I suggest to increase the default sizes for vtable and code pools (see vm/vmcore/include/mem_alloc.h).
> It reduces fragmentation of data and thus gives a little boost on specjbb2005 (as example).
> For example, the default code pool size for bootstrap classloader is 256K. Final size is about 2Mb, so it is reallocated ~6-7 times. The numbers for default classloader are: 64K - default, ~800K - final, it is realocated 11-12 times.
> The patch is attached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HARMONY-4914) [drlvm] increasing default sizes
for code and vtable pools give a little boost
Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Shimansky reassigned HARMONY-4914:
------------------------------------------
Assignee: Gregory Shimansky
> [drlvm] increasing default sizes for code and vtable pools give a little boost
> -------------------------------------------------------------------------------
>
> Key: HARMONY-4914
> URL: https://issues.apache.org/jira/browse/HARMONY-4914
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Environment: windows, linux
> Reporter: Rustem Rafikov
> Assignee: Gregory Shimansky
> Priority: Minor
> Attachments: code-size.patch, code-size.patch
>
>
> I suggest to increase the default sizes for vtable and code pools (see vm/vmcore/include/mem_alloc.h).
> It reduces fragmentation of data and thus gives a little boost on specjbb2005 (as example).
> For example, the default code pool size for bootstrap classloader is 256K. Final size is about 2Mb, so it is reallocated ~6-7 times. The numbers for default classloader are: 64K - default, ~800K - final, it is realocated 11-12 times.
> The patch is attached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-4914) [drlvm] increasing default sizes
for code and vtable pools give a little boost
Posted by "Pavel Pervov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pavel Pervov updated HARMONY-4914:
----------------------------------
Attachment: code-size.patch
I've slightly increased default pool sizes and, which is more important, added 4 additional -XX switches:
vm.code_pool_size.stubs - initial size of code pool for stubs
vm.vtable_pool_size - initial size of vtable pool (both compressed and uncompressed vtables)
vm.code_pool_size.bootstrap_loader - initial size of code pool for bootstrap class loader
vm.code_pool_size.user_loader - initial size of code pool for user class loaders
> [drlvm] increasing default sizes for code and vtable pools give a little boost
> -------------------------------------------------------------------------------
>
> Key: HARMONY-4914
> URL: https://issues.apache.org/jira/browse/HARMONY-4914
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Environment: windows, linux
> Reporter: Rustem Rafikov
> Priority: Minor
> Attachments: code-size.patch, code-size.patch
>
>
> I suggest to increase the default sizes for vtable and code pools (see vm/vmcore/include/mem_alloc.h).
> It reduces fragmentation of data and thus gives a little boost on specjbb2005 (as example).
> For example, the default code pool size for bootstrap classloader is 256K. Final size is about 2Mb, so it is reallocated ~6-7 times. The numbers for default classloader are: 64K - default, ~800K - final, it is realocated 11-12 times.
> The patch is attached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.