You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/12/08 15:34:10 UTC
[GitHub] [dubbo-go] fangyincheng opened a new pull request #914: WIP: fix path
fangyincheng opened a new pull request #914:
URL: https://github.com/apache/dubbo-go/pull/914
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on pull request #914: WIP: fix path
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #914:
URL: https://github.com/apache/dubbo-go/pull/914#issuecomment-741121293
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/914?src=pr&el=h1) Report
> Merging [#914](https://codecov.io/gh/apache/dubbo-go/pull/914?src=pr&el=desc) (c593464) into [master](https://codecov.io/gh/apache/dubbo-go/commit/9bf076cd7c6d0ea04d518db0148b0e01c4bbf25b?el=desc) (9bf076c) will **increase** coverage by `0.09%`.
> The diff coverage is `86.20%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/914?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #914 +/- ##
==========================================
+ Coverage 59.84% 59.93% +0.09%
==========================================
Files 260 260
Lines 12852 12853 +1
==========================================
+ Hits 7691 7704 +13
+ Misses 4201 4184 -17
- Partials 960 965 +5
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/914?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cluster/router/healthcheck/default\_health\_check.go](https://codecov.io/gh/apache/dubbo-go/pull/914/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvaGVhbHRoY2hlY2svZGVmYXVsdF9oZWFsdGhfY2hlY2suZ28=) | `94.11% <ø> (ø)` | |
| [common/proxy/proxy\_factory/default.go](https://codecov.io/gh/apache/dubbo-go/pull/914/diff?src=pr&el=tree#diff-Y29tbW9uL3Byb3h5L3Byb3h5X2ZhY3RvcnkvZGVmYXVsdC5nbw==) | `13.55% <0.00%> (ø)` | |
| [common/url.go](https://codecov.io/gh/apache/dubbo-go/pull/914/diff?src=pr&el=tree#diff-Y29tbW9uL3VybC5nbw==) | `58.52% <ø> (+1.92%)` | :arrow_up: |
| [metadata/service/remote/service.go](https://codecov.io/gh/apache/dubbo-go/pull/914/diff?src=pr&el=tree#diff-bWV0YWRhdGEvc2VydmljZS9yZW1vdGUvc2VydmljZS5nbw==) | `39.72% <0.00%> (ø)` | |
| [filter/filter\_impl/access\_log\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/914/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2FjY2Vzc19sb2dfZmlsdGVyLmdv) | `61.90% <60.00%> (+1.12%)` | :arrow_up: |
| [common/rpc\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/914/diff?src=pr&el=tree#diff-Y29tbW9uL3JwY19zZXJ2aWNlLmdv) | `88.11% <100.00%> (+0.16%)` | :arrow_up: |
| [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/914/diff?src=pr&el=tree#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `80.00% <100.00%> (ø)` | |
| [config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/914/diff?src=pr&el=tree#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv) | `62.67% <100.00%> (ø)` | |
| [filter/filter\_impl/generic\_service\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/914/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2dlbmVyaWNfc2VydmljZV9maWx0ZXIuZ28=) | `67.30% <100.00%> (ø)` | |
| [metadata/service/inmemory/service.go](https://codecov.io/gh/apache/dubbo-go/pull/914/diff?src=pr&el=tree#diff-bWV0YWRhdGEvc2VydmljZS9pbm1lbW9yeS9zZXJ2aWNlLmdv) | `85.22% <100.00%> (ø)` | |
| ... and [10 more](https://codecov.io/gh/apache/dubbo-go/pull/914/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/914?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/914?src=pr&el=footer). Last update [9bf076c...c593464](https://codecov.io/gh/apache/dubbo-go/pull/914?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #914: fix path
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #914:
URL: https://github.com/apache/dubbo-go/pull/914#issuecomment-741121293
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/914?src=pr&el=h1) Report
> Merging [#914](https://codecov.io/gh/apache/dubbo-go/pull/914?src=pr&el=desc) (eb011be) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/4ea5d0a7e72312f70decf033810291b0a134c661?el=desc) (4ea5d0a) will **decrease** coverage by `0.04%`.
> The diff coverage is `86.20%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/914?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #914 +/- ##
===========================================
- Coverage 59.83% 59.79% -0.05%
===========================================
Files 260 260
Lines 12854 12853 -1
===========================================
- Hits 7691 7685 -6
- Misses 4202 4204 +2
- Partials 961 964 +3
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/914?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cluster/router/healthcheck/default\_health\_check.go](https://codecov.io/gh/apache/dubbo-go/pull/914/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvaGVhbHRoY2hlY2svZGVmYXVsdF9oZWFsdGhfY2hlY2suZ28=) | `94.11% <ø> (ø)` | |
| [common/proxy/proxy\_factory/default.go](https://codecov.io/gh/apache/dubbo-go/pull/914/diff?src=pr&el=tree#diff-Y29tbW9uL3Byb3h5L3Byb3h5X2ZhY3RvcnkvZGVmYXVsdC5nbw==) | `13.55% <0.00%> (ø)` | |
| [common/url.go](https://codecov.io/gh/apache/dubbo-go/pull/914/diff?src=pr&el=tree#diff-Y29tbW9uL3VybC5nbw==) | `58.52% <ø> (+1.92%)` | :arrow_up: |
| [metadata/service/remote/service.go](https://codecov.io/gh/apache/dubbo-go/pull/914/diff?src=pr&el=tree#diff-bWV0YWRhdGEvc2VydmljZS9yZW1vdGUvc2VydmljZS5nbw==) | `39.72% <0.00%> (ø)` | |
| [filter/filter\_impl/access\_log\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/914/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2FjY2Vzc19sb2dfZmlsdGVyLmdv) | `61.90% <60.00%> (+1.12%)` | :arrow_up: |
| [common/rpc\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/914/diff?src=pr&el=tree#diff-Y29tbW9uL3JwY19zZXJ2aWNlLmdv) | `88.11% <100.00%> (+0.16%)` | :arrow_up: |
| [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/914/diff?src=pr&el=tree#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `80.00% <100.00%> (ø)` | |
| [config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/914/diff?src=pr&el=tree#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv) | `62.67% <100.00%> (ø)` | |
| [filter/filter\_impl/generic\_service\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/914/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2dlbmVyaWNfc2VydmljZV9maWx0ZXIuZ28=) | `67.30% <100.00%> (ø)` | |
| [metadata/service/inmemory/service.go](https://codecov.io/gh/apache/dubbo-go/pull/914/diff?src=pr&el=tree#diff-bWV0YWRhdGEvc2VydmljZS9pbm1lbW9yeS9zZXJ2aWNlLmdv) | `85.22% <100.00%> (ø)` | |
| ... and [13 more](https://codecov.io/gh/apache/dubbo-go/pull/914/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/914?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/914?src=pr&el=footer). Last update [4ea5d0a...f7995eb](https://codecov.io/gh/apache/dubbo-go/pull/914?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #914: fix path
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #914:
URL: https://github.com/apache/dubbo-go/pull/914#issuecomment-741121293
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/914?src=pr&el=h1) Report
> Merging [#914](https://codecov.io/gh/apache/dubbo-go/pull/914?src=pr&el=desc) (f7995eb) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/4ea5d0a7e72312f70decf033810291b0a134c661?el=desc) (4ea5d0a) will **decrease** coverage by `0.06%`.
> The diff coverage is `86.20%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/914?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #914 +/- ##
===========================================
- Coverage 59.83% 59.76% -0.07%
===========================================
Files 260 260
Lines 12854 12855 +1
===========================================
- Hits 7691 7683 -8
- Misses 4202 4205 +3
- Partials 961 967 +6
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/914?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cluster/router/healthcheck/default\_health\_check.go](https://codecov.io/gh/apache/dubbo-go/pull/914/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvaGVhbHRoY2hlY2svZGVmYXVsdF9oZWFsdGhfY2hlY2suZ28=) | `94.11% <ø> (ø)` | |
| [common/proxy/proxy\_factory/default.go](https://codecov.io/gh/apache/dubbo-go/pull/914/diff?src=pr&el=tree#diff-Y29tbW9uL3Byb3h5L3Byb3h5X2ZhY3RvcnkvZGVmYXVsdC5nbw==) | `13.55% <0.00%> (ø)` | |
| [common/url.go](https://codecov.io/gh/apache/dubbo-go/pull/914/diff?src=pr&el=tree#diff-Y29tbW9uL3VybC5nbw==) | `58.52% <ø> (+1.92%)` | :arrow_up: |
| [metadata/service/remote/service.go](https://codecov.io/gh/apache/dubbo-go/pull/914/diff?src=pr&el=tree#diff-bWV0YWRhdGEvc2VydmljZS9yZW1vdGUvc2VydmljZS5nbw==) | `39.72% <0.00%> (ø)` | |
| [filter/filter\_impl/access\_log\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/914/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2FjY2Vzc19sb2dfZmlsdGVyLmdv) | `61.90% <60.00%> (+1.12%)` | :arrow_up: |
| [common/rpc\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/914/diff?src=pr&el=tree#diff-Y29tbW9uL3JwY19zZXJ2aWNlLmdv) | `88.11% <100.00%> (+0.16%)` | :arrow_up: |
| [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/914/diff?src=pr&el=tree#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `80.00% <100.00%> (ø)` | |
| [config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/914/diff?src=pr&el=tree#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv) | `62.67% <100.00%> (ø)` | |
| [filter/filter\_impl/generic\_service\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/914/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2dlbmVyaWNfc2VydmljZV9maWx0ZXIuZ28=) | `67.30% <100.00%> (ø)` | |
| [metadata/service/inmemory/service.go](https://codecov.io/gh/apache/dubbo-go/pull/914/diff?src=pr&el=tree#diff-bWV0YWRhdGEvc2VydmljZS9pbm1lbW9yeS9zZXJ2aWNlLmdv) | `85.22% <100.00%> (ø)` | |
| ... and [9 more](https://codecov.io/gh/apache/dubbo-go/pull/914/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/914?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/914?src=pr&el=footer). Last update [4ea5d0a...f7995eb](https://codecov.io/gh/apache/dubbo-go/pull/914?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #914: fix path
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #914:
URL: https://github.com/apache/dubbo-go/pull/914#issuecomment-741121293
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/914?src=pr&el=h1) Report
> Merging [#914](https://codecov.io/gh/apache/dubbo-go/pull/914?src=pr&el=desc) (f7995eb) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/4ea5d0a7e72312f70decf033810291b0a134c661?el=desc) (4ea5d0a) will **increase** coverage by `0.01%`.
> The diff coverage is `86.20%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/914?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #914 +/- ##
===========================================
+ Coverage 59.83% 59.84% +0.01%
===========================================
Files 260 260
Lines 12854 12855 +1
===========================================
+ Hits 7691 7693 +2
+ Misses 4202 4198 -4
- Partials 961 964 +3
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/914?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cluster/router/healthcheck/default\_health\_check.go](https://codecov.io/gh/apache/dubbo-go/pull/914/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvaGVhbHRoY2hlY2svZGVmYXVsdF9oZWFsdGhfY2hlY2suZ28=) | `94.11% <ø> (ø)` | |
| [common/proxy/proxy\_factory/default.go](https://codecov.io/gh/apache/dubbo-go/pull/914/diff?src=pr&el=tree#diff-Y29tbW9uL3Byb3h5L3Byb3h5X2ZhY3RvcnkvZGVmYXVsdC5nbw==) | `13.55% <0.00%> (ø)` | |
| [common/url.go](https://codecov.io/gh/apache/dubbo-go/pull/914/diff?src=pr&el=tree#diff-Y29tbW9uL3VybC5nbw==) | `58.52% <ø> (+1.92%)` | :arrow_up: |
| [metadata/service/remote/service.go](https://codecov.io/gh/apache/dubbo-go/pull/914/diff?src=pr&el=tree#diff-bWV0YWRhdGEvc2VydmljZS9yZW1vdGUvc2VydmljZS5nbw==) | `39.72% <0.00%> (ø)` | |
| [filter/filter\_impl/access\_log\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/914/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2FjY2Vzc19sb2dfZmlsdGVyLmdv) | `61.90% <60.00%> (+1.12%)` | :arrow_up: |
| [common/rpc\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/914/diff?src=pr&el=tree#diff-Y29tbW9uL3JwY19zZXJ2aWNlLmdv) | `88.11% <100.00%> (+0.16%)` | :arrow_up: |
| [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/914/diff?src=pr&el=tree#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `80.00% <100.00%> (ø)` | |
| [config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/914/diff?src=pr&el=tree#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv) | `62.67% <100.00%> (ø)` | |
| [filter/filter\_impl/generic\_service\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/914/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2dlbmVyaWNfc2VydmljZV9maWx0ZXIuZ28=) | `67.30% <100.00%> (ø)` | |
| [metadata/service/inmemory/service.go](https://codecov.io/gh/apache/dubbo-go/pull/914/diff?src=pr&el=tree#diff-bWV0YWRhdGEvc2VydmljZS9pbm1lbW9yeS9zZXJ2aWNlLmdv) | `85.22% <100.00%> (ø)` | |
| ... and [9 more](https://codecov.io/gh/apache/dubbo-go/pull/914/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/914?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/914?src=pr&el=footer). Last update [4ea5d0a...f7995eb](https://codecov.io/gh/apache/dubbo-go/pull/914?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] zouyx merged pull request #914: fix path
Posted by GitBox <gi...@apache.org>.
zouyx merged pull request #914:
URL: https://github.com/apache/dubbo-go/pull/914
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org