You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2018/01/03 16:59:22 UTC
[GitHub] eolivelli commented on a change in pull request #932: ISSUE #931,#907: Add option to track task execution time
eolivelli commented on a change in pull request #932: ISSUE #931,#907: Add option to track task execution time
URL: https://github.com/apache/bookkeeper/pull/932#discussion_r159473753
##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieRequestProcessor.java
##########
@@ -142,16 +143,21 @@ public BookieRequestProcessor(ServerConfiguration serverCfg, Bookie bookie,
StatsLogger statsLogger, SecurityHandlerFactory shFactory) throws SecurityException {
this.serverCfg = serverCfg;
this.bookie = bookie;
- this.readThreadPool = createExecutor(this.serverCfg.getNumReadWorkerThreads(),
- "BookieReadThread-" + serverCfg.getBookiePort(),
- serverCfg.getMaxPendingReadRequestPerThread());
- this.writeThreadPool = createExecutor(this.serverCfg.getNumAddWorkerThreads(),
- "BookieWriteThread-" + serverCfg.getBookiePort(),
- serverCfg.getMaxPendingAddRequestPerThread());
- this.longPollThreadPool =
- createExecutor(
+ this.readThreadPool = createExecutor(
+ this.serverCfg.getNumReadWorkerThreads(),
+ "BookieReadThreadPool",
+ serverCfg.getMaxPendingReadRequestPerThread(),
+ statsLogger);
+ this.writeThreadPool = createExecutor(
+ this.serverCfg.getNumAddWorkerThreads(),
+ "BookieWriteThreadPool",
+ serverCfg.getMaxPendingAddRequestPerThread(),
+ statsLogger);
+ this.longPollThreadPool = createExecutor(
this.serverCfg.getNumLongPollWorkerThreads(),
- "BookieLongPollThread-" + serverCfg.getBookiePort(), OrderedScheduler.NO_TASK_LIMIT);
+ "BookieLongPollThread",
+ OrderedScheduler.NO_TASK_LIMIT,
+ NullStatsLogger.INSTANCE);
Review comment:
Can't we pass the statslogger here as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services