You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/12/27 10:37:50 UTC

[GitHub] [skywalking-client-js] Fine0830 commented on a diff in pull request #106: feature: auto trace SPA performance when router change

Fine0830 commented on code in PR #106:
URL: https://github.com/apache/skywalking-client-js/pull/106#discussion_r1057590895


##########
src/monitor.ts:
##########
@@ -42,9 +42,7 @@ const ClientMonitor = {
     };
     this.validateOptions();
     this.catchErrors(this.customOptions);
-    if (!this.customOptions.enableSPA) {

Review Comment:
   Since the `enableSPA` turns on single page mode, you can't change this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org