You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "lidavidm (via GitHub)" <gi...@apache.org> on 2024/07/28 23:57:28 UTC
[PR] GH-43455: [Go] Add Opaque canonical extension type [arrow]
lidavidm opened a new pull request, #43459:
URL: https://github.com/apache/arrow/pull/43459
### Rationale for this change
Add the newly ratified extension type.
### What changes are included in this PR?
The Go implementation only.
### Are these changes tested?
Yes
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43455: [Go] Add Opaque canonical extension type [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #43459:
URL: https://github.com/apache/arrow/pull/43459#issuecomment-2272294002
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit dea09ec9c0dd0d6f68b67101dc520ac737eac277.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/28433070659) has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43455: [Go] Add Opaque canonical extension type [arrow]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade merged PR #43459:
URL: https://github.com/apache/arrow/pull/43459
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43455: [Go] Add Opaque canonical extension type [arrow]
Posted by "joellubi (via GitHub)" <gi...@apache.org>.
joellubi commented on code in PR #43459:
URL: https://github.com/apache/arrow/pull/43459#discussion_r1702197252
##########
go/arrow/extensions/opaque.go:
##########
@@ -0,0 +1,105 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package extensions
+
+import (
+ "encoding/json"
+ "fmt"
+ "reflect"
+ "unsafe"
+
+ "github.com/apache/arrow/go/v18/arrow"
+ "github.com/apache/arrow/go/v18/arrow/array"
+)
+
+// OpaqueType is a placeholder for a type from an external (usually
+// non-Arrow) system that could not be interpreted.
+type OpaqueType struct {
+ arrow.ExtensionBase `json:"-"`
+
+ TypeName string `json:"type_name"`
+ VendorName string `json:"vendor_name"`
+}
+
+func NewOpaqueType(storageType arrow.DataType, name, vendorName string) *OpaqueType {
Review Comment:
```suggestion
// NewOpaqueType creates a new OpaqueType with the provided storage type, type name, and vendor name.
func NewOpaqueType(storageType arrow.DataType, name, vendorName string) *OpaqueType {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43455: [Go] Add Opaque canonical extension type [arrow]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #43459:
URL: https://github.com/apache/arrow/pull/43459#issuecomment-2270154000
Any further comments here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43455: [Go] Add Opaque canonical extension type [arrow]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #43459:
URL: https://github.com/apache/arrow/pull/43459#issuecomment-2264295189
rebased + fixed the author before I merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43455: [Go] Add Opaque canonical extension type [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #43459:
URL: https://github.com/apache/arrow/pull/43459#issuecomment-2254711508
:warning: GitHub issue #43455 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org