You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "yaooqinn (via GitHub)" <gi...@apache.org> on 2023/04/03 09:04:10 UTC
[GitHub] [spark] yaooqinn commented on a diff in pull request #40437: [SPARK-41259][SQL] SparkSQLDriver Output schema and result string should be consistent
yaooqinn commented on code in PR #40437:
URL: https://github.com/apache/spark/pull/40437#discussion_r1155683471
##########
sql/core/src/test/resources/sql-tests/results/show-tables.sql.out:
##########
@@ -60,58 +60,58 @@ SHOW TABLES
-- !query schema
struct<namespace:string,tableName:string,isTemporary:boolean>
-- !query output
-show_t1
-show_t2
-show_t3
+ show_t3 true
Review Comment:
It did not go through the Hive CLI path
- For `-- !query schema`, we use Dataframe.schema
- For `-- !query output`,
- `SQLQueryTestSuite` uses hiveResultString directly
- `ThriftServerQueryTestSuite` bypasses validation from 'show xxx' (cc @Yikf we shall enable these in this PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org