[jira] [Resolved] (WICKET-4736) JavaScriptFilteredIntoFooterHeaderResponse should reverse filter logic

["Martin Grigorov (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/WICKET-4736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Grigorov resolved WICKET-4736.
-------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.5.9
                   6.0.1
         Assignee: Martin Grigorov

Fixed.

The APIs were broke but since the class is final there is no chance that someone has overridden it.
                
> JavaScriptFilteredIntoFooterHeaderResponse should reverse filter logic
> ----------------------------------------------------------------------
>
>                 Key: WICKET-4736
>                 URL: https://issues.apache.org/jira/browse/WICKET-4736
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.5.8, 6.0.0
>            Reporter: Christoph Leiter
>            Assignee: Martin Grigorov
>             Fix For: 6.0.1, 1.5.9
>
>
> JavaScriptFilteredIntoFooterHeaderResponse creates two buckets. One for CSS and one for JS. The current logic is that everything that isn't CSS must be JS and so gets put at the bottom of the page. This breaks if CssAcceptingHeaderResponseFilter mistakingly identifies something as non-CSS (eg a CSS file with another extension). Also everything else that isn't CSS gets put into the footer bucket (which should contain only JS).
> It would be better if it only puts things in the footer bucket if it can determine that it's JS and sort everything else into the header bucket.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira