You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/07/31 08:57:00 UTC
[jira] [Commented] (FLINK-9987) Rework ClassLoader E2E test to not
rely on .version.properties file
[ https://issues.apache.org/jira/browse/FLINK-9987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563320#comment-16563320 ]
ASF GitHub Bot commented on FLINK-9987:
---------------------------------------
twalthr commented on a change in pull request #6442: [FLINK-9987][tests] Harden ClassLoader E2E test
URL: https://github.com/apache/flink/pull/6442#discussion_r206431097
##########
File path: flink-end-to-end-tests/flink-parent-child-classloading-test/src/main/java/org/apache/flink/streaming/tests/ClassLoaderTestProgram.java
##########
@@ -67,7 +67,7 @@ public static void main(String[] args) throws Exception {
try (InputStream in = url.openStream()) {
Properties properties = new Properties();
properties.load(in);
- String orderedGitUrl = properties.getProperty("git.remote.origin.url");
+ String orderedGitUrl = properties.getProperty("git.commit.id.abbrev");
Review comment:
Update variable name as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Rework ClassLoader E2E test to not rely on .version.properties file
> -------------------------------------------------------------------
>
> Key: FLINK-9987
> URL: https://issues.apache.org/jira/browse/FLINK-9987
> Project: Flink
> Issue Type: Improvement
> Components: Tests
> Affects Versions: 1.5.0, 1.6.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.6.0
>
>
> The classloading end-to-end test makes use of the {{.version.properties}} file that is bundled with flink-runtime to ensure classloading works properly.
> In particular it access the {{git.remote.origin.url}} property.
> This should be changed since this property isn't stable across builds, which results in test failures when running the e2e tests against a release that was built on a different machine.
> The test furthermore relies on this file also existing in the source flink-runtime module, which is a dangerous assumption as this requires flink-runtime to be built beforehand. It is also _yet another_ instance where we navigate out of a module which should never be done.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)