You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Attila Doroszlai <ad...@hortonworks.com> on 2017/08/02 09:13:15 UTC

Review Request 61371: AMBARI-21624. HDFS restart failed post Ambari upgrade when lzo compression was enabled

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61371/
-----------------------------------------------------------

Review request for Ambari, Di Li, Sid Wagle, and Tim Thorpe.


Bugs: AMBARI-21624
    https://issues.apache.org/jira/browse/AMBARI-21624


Repository: ambari


Description
-------

The list of lzo packages for BI 4.2 is hard-coded in Ambari 2.5.2's stack definition.  Use the same list for BI 4.2.5.

* Copied HDFS `package` from IBM Ambari 2.4.2's `common-services`
* Replaced `get_lzo_packages` call with list of packages.
* Also needed to replace `Script.get_force_https_protocol` calls due to the change made in AMBARI-20857.


Diffs
-----

  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/alerts/alert_checkpoint_time.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/alerts/alert_datanode_unmounted_data_dir.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/alerts/alert_ha_namenode_health.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/alerts/alert_metrics_deviation.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/alerts/alert_upgrade_finalized.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/files/checkWebUI.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/__init__.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/balancer-emulator/balancer-err.log PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/balancer-emulator/balancer.log PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/balancer-emulator/hdfs-command.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/datanode.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/datanode_upgrade.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/hdfs.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/hdfs_client.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/hdfs_datanode.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/hdfs_namenode.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/hdfs_nfsgateway.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/hdfs_rebalance.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/hdfs_snamenode.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/install_params.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/journalnode.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/journalnode_upgrade.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/namenode.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/namenode_ha_state.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/namenode_upgrade.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/nfsgateway.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/params.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/params_linux.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/params_windows.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/service_check.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/setup_ranger_hdfs.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/snamenode.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/status_params.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/utils.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/zkfc_slave.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/templates/exclude_hosts_list.j2 PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/templates/hdfs.conf.j2 PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/templates/slaves.j2 PRE-CREATION 


Diff: https://reviews.apache.org/r/61371/diff/1/


Testing
-------

Tested manually on local cluster: restart HDFS, run service check, perform stack upgrade.


Thanks,

Attila Doroszlai


Re: Review Request 61371: AMBARI-21624. HDFS restart failed post Ambari upgrade when lzo compression was enabled

Posted by Di Li <di...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61371/#review181974
-----------------------------------------------------------




ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/balancer-emulator/balancer.log
Lines 2 (patched)
<https://reviews.apache.org/r/61371/#comment257808>

    I don't think we need the two balancer log files as part of the HDFS service definition. Please remove them if they are not necessary.


- Di Li


On Aug. 2, 2017, 9:13 a.m., Attila Doroszlai wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61371/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2017, 9:13 a.m.)
> 
> 
> Review request for Ambari, Di Li, Sid Wagle, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21624
>     https://issues.apache.org/jira/browse/AMBARI-21624
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The list of lzo packages for BI 4.2 is hard-coded in Ambari 2.5.2's stack definition.  Use the same list for BI 4.2.5.
> 
> * Copied HDFS `package` from IBM Ambari 2.4.2's `common-services`
> * Replaced `get_lzo_packages` call with list of packages.
> * Also needed to replace `Script.get_force_https_protocol` calls due to the change made in AMBARI-20857.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/alerts/alert_checkpoint_time.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/alerts/alert_datanode_unmounted_data_dir.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/alerts/alert_ha_namenode_health.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/alerts/alert_metrics_deviation.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/alerts/alert_upgrade_finalized.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/files/checkWebUI.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/__init__.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/balancer-emulator/balancer-err.log PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/balancer-emulator/balancer.log PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/balancer-emulator/hdfs-command.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/datanode.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/datanode_upgrade.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/hdfs.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/hdfs_client.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/hdfs_datanode.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/hdfs_namenode.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/hdfs_nfsgateway.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/hdfs_rebalance.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/hdfs_snamenode.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/install_params.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/journalnode.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/journalnode_upgrade.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/namenode.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/namenode_ha_state.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/namenode_upgrade.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/nfsgateway.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/params.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/params_linux.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/params_windows.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/service_check.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/setup_ranger_hdfs.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/snamenode.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/status_params.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/utils.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/zkfc_slave.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/templates/exclude_hosts_list.j2 PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/templates/hdfs.conf.j2 PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/templates/slaves.j2 PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/61371/diff/1/
> 
> 
> Testing
> -------
> 
> Tested manually on local cluster: restart HDFS, run service check, perform stack upgrade.
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>


Re: Review Request 61371: AMBARI-21624. HDFS restart failed post Ambari upgrade when lzo compression was enabled

Posted by Di Li <di...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61371/#review181983
-----------------------------------------------------------


Ship it!




Ship It!

- Di Li


On Aug. 2, 2017, 1:12 p.m., Attila Doroszlai wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61371/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2017, 1:12 p.m.)
> 
> 
> Review request for Ambari, Di Li, Sid Wagle, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21624
>     https://issues.apache.org/jira/browse/AMBARI-21624
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The list of lzo packages for BI 4.2 is hard-coded in Ambari 2.5.2's stack definition.  Use the same list for BI 4.2.5.
> 
> * Copied HDFS `package` from IBM Ambari 2.4.2's `common-services`
> * Replaced `get_lzo_packages` call with list of packages.
> * Also needed to replace `Script.get_force_https_protocol` calls due to the change made in AMBARI-20857.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/alerts/alert_checkpoint_time.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/alerts/alert_datanode_unmounted_data_dir.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/alerts/alert_ha_namenode_health.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/alerts/alert_metrics_deviation.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/alerts/alert_upgrade_finalized.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/files/checkWebUI.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/__init__.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/balancer-emulator/hdfs-command.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/datanode.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/datanode_upgrade.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/hdfs.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/hdfs_client.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/hdfs_datanode.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/hdfs_namenode.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/hdfs_nfsgateway.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/hdfs_rebalance.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/hdfs_snamenode.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/install_params.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/journalnode.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/journalnode_upgrade.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/namenode.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/namenode_ha_state.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/namenode_upgrade.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/nfsgateway.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/params.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/params_linux.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/params_windows.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/service_check.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/setup_ranger_hdfs.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/snamenode.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/status_params.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/utils.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/zkfc_slave.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/templates/exclude_hosts_list.j2 PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/templates/hdfs.conf.j2 PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/templates/slaves.j2 PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/61371/diff/2/
> 
> 
> Testing
> -------
> 
> Tested manually on local cluster: restart HDFS, run service check, perform stack upgrade.
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>


Re: Review Request 61371: AMBARI-21624. HDFS restart failed post Ambari upgrade when lzo compression was enabled

Posted by Tim Thorpe <tt...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61371/#review181982
-----------------------------------------------------------


Ship it!




Ship It!

- Tim Thorpe


On Aug. 2, 2017, 1:12 p.m., Attila Doroszlai wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61371/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2017, 1:12 p.m.)
> 
> 
> Review request for Ambari, Di Li, Sid Wagle, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21624
>     https://issues.apache.org/jira/browse/AMBARI-21624
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The list of lzo packages for BI 4.2 is hard-coded in Ambari 2.5.2's stack definition.  Use the same list for BI 4.2.5.
> 
> * Copied HDFS `package` from IBM Ambari 2.4.2's `common-services`
> * Replaced `get_lzo_packages` call with list of packages.
> * Also needed to replace `Script.get_force_https_protocol` calls due to the change made in AMBARI-20857.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/alerts/alert_checkpoint_time.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/alerts/alert_datanode_unmounted_data_dir.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/alerts/alert_ha_namenode_health.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/alerts/alert_metrics_deviation.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/alerts/alert_upgrade_finalized.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/files/checkWebUI.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/__init__.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/balancer-emulator/hdfs-command.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/datanode.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/datanode_upgrade.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/hdfs.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/hdfs_client.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/hdfs_datanode.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/hdfs_namenode.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/hdfs_nfsgateway.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/hdfs_rebalance.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/hdfs_snamenode.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/install_params.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/journalnode.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/journalnode_upgrade.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/namenode.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/namenode_ha_state.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/namenode_upgrade.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/nfsgateway.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/params.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/params_linux.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/params_windows.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/service_check.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/setup_ranger_hdfs.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/snamenode.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/status_params.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/utils.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/zkfc_slave.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/templates/exclude_hosts_list.j2 PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/templates/hdfs.conf.j2 PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/templates/slaves.j2 PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/61371/diff/2/
> 
> 
> Testing
> -------
> 
> Tested manually on local cluster: restart HDFS, run service check, perform stack upgrade.
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>


Re: Review Request 61371: AMBARI-21624. HDFS restart failed post Ambari upgrade when lzo compression was enabled

Posted by Attila Doroszlai <ad...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61371/
-----------------------------------------------------------

(Updated Aug. 2, 2017, 3:12 p.m.)


Review request for Ambari, Di Li, Sid Wagle, and Tim Thorpe.


Changes
-------

removed balancer log files


Bugs: AMBARI-21624
    https://issues.apache.org/jira/browse/AMBARI-21624


Repository: ambari


Description
-------

The list of lzo packages for BI 4.2 is hard-coded in Ambari 2.5.2's stack definition.  Use the same list for BI 4.2.5.

* Copied HDFS `package` from IBM Ambari 2.4.2's `common-services`
* Replaced `get_lzo_packages` call with list of packages.
* Also needed to replace `Script.get_force_https_protocol` calls due to the change made in AMBARI-20857.


Diffs (updated)
-----

  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/alerts/alert_checkpoint_time.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/alerts/alert_datanode_unmounted_data_dir.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/alerts/alert_ha_namenode_health.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/alerts/alert_metrics_deviation.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/alerts/alert_upgrade_finalized.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/files/checkWebUI.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/__init__.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/balancer-emulator/hdfs-command.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/datanode.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/datanode_upgrade.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/hdfs.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/hdfs_client.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/hdfs_datanode.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/hdfs_namenode.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/hdfs_nfsgateway.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/hdfs_rebalance.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/hdfs_snamenode.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/install_params.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/journalnode.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/journalnode_upgrade.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/namenode.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/namenode_ha_state.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/namenode_upgrade.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/nfsgateway.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/params.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/params_linux.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/params_windows.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/service_check.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/setup_ranger_hdfs.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/snamenode.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/status_params.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/utils.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/zkfc_slave.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/templates/exclude_hosts_list.j2 PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/templates/hdfs.conf.j2 PRE-CREATION 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/templates/slaves.j2 PRE-CREATION 


Diff: https://reviews.apache.org/r/61371/diff/2/

Changes: https://reviews.apache.org/r/61371/diff/1-2/


Testing
-------

Tested manually on local cluster: restart HDFS, run service check, perform stack upgrade.


Thanks,

Attila Doroszlai


Re: Review Request 61371: AMBARI-21624. HDFS restart failed post Ambari upgrade when lzo compression was enabled

Posted by Tim Thorpe <tt...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61371/#review181965
-----------------------------------------------------------


Ship it!




Ship It!

- Tim Thorpe


On Aug. 2, 2017, 9:13 a.m., Attila Doroszlai wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61371/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2017, 9:13 a.m.)
> 
> 
> Review request for Ambari, Di Li, Sid Wagle, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21624
>     https://issues.apache.org/jira/browse/AMBARI-21624
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The list of lzo packages for BI 4.2 is hard-coded in Ambari 2.5.2's stack definition.  Use the same list for BI 4.2.5.
> 
> * Copied HDFS `package` from IBM Ambari 2.4.2's `common-services`
> * Replaced `get_lzo_packages` call with list of packages.
> * Also needed to replace `Script.get_force_https_protocol` calls due to the change made in AMBARI-20857.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/alerts/alert_checkpoint_time.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/alerts/alert_datanode_unmounted_data_dir.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/alerts/alert_ha_namenode_health.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/alerts/alert_metrics_deviation.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/alerts/alert_upgrade_finalized.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/files/checkWebUI.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/__init__.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/balancer-emulator/balancer-err.log PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/balancer-emulator/balancer.log PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/balancer-emulator/hdfs-command.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/datanode.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/datanode_upgrade.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/hdfs.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/hdfs_client.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/hdfs_datanode.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/hdfs_namenode.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/hdfs_nfsgateway.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/hdfs_rebalance.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/hdfs_snamenode.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/install_params.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/journalnode.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/journalnode_upgrade.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/namenode.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/namenode_ha_state.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/namenode_upgrade.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/nfsgateway.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/params.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/params_linux.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/params_windows.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/service_check.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/setup_ranger_hdfs.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/snamenode.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/status_params.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/utils.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/zkfc_slave.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/templates/exclude_hosts_list.j2 PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/templates/hdfs.conf.j2 PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/templates/slaves.j2 PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/61371/diff/1/
> 
> 
> Testing
> -------
> 
> Tested manually on local cluster: restart HDFS, run service check, perform stack upgrade.
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>


Re: Review Request 61371: AMBARI-21624. HDFS restart failed post Ambari upgrade when lzo compression was enabled

Posted by Tim Thorpe <tt...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61371/#review181963
-----------------------------------------------------------




ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/balancer-emulator/balancer-err.log
Lines 1 (patched)
<https://reviews.apache.org/r/61371/#comment257801>

    This should either be removed to avoid the license file issue or added to the exception list in the pom.



ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/balancer-emulator/balancer.log
Lines 1 (patched)
<https://reviews.apache.org/r/61371/#comment257800>

    This should either be removed to avoid the license file issue or added to the exception list in the pom.


- Tim Thorpe


On Aug. 2, 2017, 9:13 a.m., Attila Doroszlai wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61371/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2017, 9:13 a.m.)
> 
> 
> Review request for Ambari, Di Li, Sid Wagle, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21624
>     https://issues.apache.org/jira/browse/AMBARI-21624
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The list of lzo packages for BI 4.2 is hard-coded in Ambari 2.5.2's stack definition.  Use the same list for BI 4.2.5.
> 
> * Copied HDFS `package` from IBM Ambari 2.4.2's `common-services`
> * Replaced `get_lzo_packages` call with list of packages.
> * Also needed to replace `Script.get_force_https_protocol` calls due to the change made in AMBARI-20857.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/alerts/alert_checkpoint_time.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/alerts/alert_datanode_unmounted_data_dir.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/alerts/alert_ha_namenode_health.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/alerts/alert_metrics_deviation.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/alerts/alert_upgrade_finalized.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/files/checkWebUI.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/__init__.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/balancer-emulator/balancer-err.log PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/balancer-emulator/balancer.log PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/balancer-emulator/hdfs-command.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/datanode.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/datanode_upgrade.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/hdfs.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/hdfs_client.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/hdfs_datanode.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/hdfs_namenode.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/hdfs_nfsgateway.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/hdfs_rebalance.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/hdfs_snamenode.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/install_params.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/journalnode.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/journalnode_upgrade.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/namenode.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/namenode_ha_state.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/namenode_upgrade.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/nfsgateway.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/params.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/params_linux.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/params_windows.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/service_check.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/setup_ranger_hdfs.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/snamenode.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/status_params.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/utils.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/zkfc_slave.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/templates/exclude_hosts_list.j2 PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/templates/hdfs.conf.j2 PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/templates/slaves.j2 PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/61371/diff/1/
> 
> 
> Testing
> -------
> 
> Tested manually on local cluster: restart HDFS, run service check, perform stack upgrade.
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>


Re: Review Request 61371: AMBARI-21624. HDFS restart failed post Ambari upgrade when lzo compression was enabled

Posted by Di Li <di...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61371/#review181973
-----------------------------------------------------------


Ship it!




Ship It!

- Di Li


On Aug. 2, 2017, 9:13 a.m., Attila Doroszlai wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61371/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2017, 9:13 a.m.)
> 
> 
> Review request for Ambari, Di Li, Sid Wagle, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21624
>     https://issues.apache.org/jira/browse/AMBARI-21624
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The list of lzo packages for BI 4.2 is hard-coded in Ambari 2.5.2's stack definition.  Use the same list for BI 4.2.5.
> 
> * Copied HDFS `package` from IBM Ambari 2.4.2's `common-services`
> * Replaced `get_lzo_packages` call with list of packages.
> * Also needed to replace `Script.get_force_https_protocol` calls due to the change made in AMBARI-20857.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/alerts/alert_checkpoint_time.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/alerts/alert_datanode_unmounted_data_dir.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/alerts/alert_ha_namenode_health.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/alerts/alert_metrics_deviation.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/alerts/alert_upgrade_finalized.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/files/checkWebUI.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/__init__.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/balancer-emulator/balancer-err.log PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/balancer-emulator/balancer.log PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/balancer-emulator/hdfs-command.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/datanode.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/datanode_upgrade.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/hdfs.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/hdfs_client.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/hdfs_datanode.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/hdfs_namenode.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/hdfs_nfsgateway.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/hdfs_rebalance.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/hdfs_snamenode.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/install_params.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/journalnode.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/journalnode_upgrade.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/namenode.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/namenode_ha_state.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/namenode_upgrade.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/nfsgateway.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/params.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/params_linux.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/params_windows.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/service_check.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/setup_ranger_hdfs.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/snamenode.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/status_params.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/utils.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/zkfc_slave.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/templates/exclude_hosts_list.j2 PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/templates/hdfs.conf.j2 PRE-CREATION 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/templates/slaves.j2 PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/61371/diff/1/
> 
> 
> Testing
> -------
> 
> Tested manually on local cluster: restart HDFS, run service check, perform stack upgrade.
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>