You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by markhamstra <gi...@git.apache.org> on 2017/02/13 16:26:06 UTC

[GitHub] spark issue #16905: [SPARK-19567][CORE][SCHEDULER] Support some Schedulable ...

Github user markhamstra commented on the issue:

    https://github.com/apache/spark/pull/16905
  
    @srowen These refactorings of unnecessary vars to vals is something that we've noted in the discussions of a few other PRs as something that could and probably should be done in a separate PR (i.e. this one).
    
    @erenavsarogullari There is another such refactoring that can be rolled into this PR.  See the changes that I've made to `rootPool` in `TaskSchedulerImpl`, `DAGSchedulerSuite` and `ExternalClusterManagerSuite` here: https://github.com/markhamstra/spark/commit/e11fe2a9817559492daee03c8c025879dc44d346


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org