You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/07/14 12:12:37 UTC
[GitHub] [rocketmq] yglovewms opened a new pull request #3145: [ISSUES #3078] [ISSUES #3027]add the MQReactiveAdjustFlow for the DefaultPushConsumer,add a default namesrvAdress for the example module
yglovewms opened a new pull request #3145:
URL: https://github.com/apache/rocketmq/pull/3145
**Make sure set the target branch to `develop`**
[ISSUES #3078][ISSUES #3027]
## Change what
**1.Use the principle of TCP sliding window，adjust the pull interval according to the number of messages that piled up，users can customize the upper and lower limits, step size, check time;this prevents message accumulation，much simpler than the previous method，does not affect other modules;
2.add an use example
3.add the unit tests**
***the second commit:
add the default_namesrv_address for all the sample,solve the issue that some sample was "connect to null"when run on the idea, and store the address in StartUpConstants so that we can change the address uniformly***
## How to use
**The user only needs to add this piece of code**
## Verifying this change
**Set detection 2000. When the stacked message is more than 2000, increase the pull interval, if the Stacked message is less than the threshold, decrease the pull interval.
If no message arrives, the check does not run.**
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [x] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls commented on pull request #3145: [ISSUES #3078] [ISSUES #3027]add the MQReactiveAdjustFlow for the DefaultPushConsumer,add a default namesrvAdress for the example module
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #3145:
URL: https://github.com/apache/rocketmq/pull/3145#issuecomment-880123619
[](https://coveralls.io/builds/41362091)
Coverage decreased (-0.06%) to 54.015% when pulling **5f1af7b80f560f17965602072e261e2705ab0bfc on yglovewms:master** into **30058cffa5a2512894a61b5c5eb97a58ce6681ec on apache:develop**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org