You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/02/10 13:01:43 UTC

[GitHub] [incubator-kyuubi] cxzl25 opened a new pull request #1890: [KYUUBI #1889] Improve the user experience of the configuration parameters of the document

cxzl25 opened a new pull request #1890:
URL: https://github.com/apache/incubator-kyuubi/pull/1890


   ### _Why are the changes needed?_
   https://kyuubi.apache.org/docs/latest/deployment/settings.html
   The configuration parameters in the document are too long and a newline is inserted(`<br/>`), which makes it difficult to search.
   And if the user copies the configuration parameters, it may become several lines.
   
   ### _How was this patch tested?_
   - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
   
   - [ ] Add screenshots for manual tests if appropriate
   
   - [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] pan3793 commented on pull request #1890: [KYUUBI #1889] Improve the user experience of the configuration parameters of the document

Posted by GitBox <gi...@apache.org>.
pan3793 commented on pull request #1890:
URL: https://github.com/apache/incubator-kyuubi/pull/1890#issuecomment-1034903803


   I remember there are other places in `docs/` also use `<br/>`, please also change them to make the doc consistent


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] cxzl25 edited a comment on pull request #1890: [KYUUBI #1889] Improve the user experience of the configuration parameters of the document

Posted by GitBox <gi...@apache.org>.
cxzl25 edited a comment on pull request #1890:
URL: https://github.com/apache/incubator-kyuubi/pull/1890#issuecomment-1035095817


   > I remember there are other places in `docs/` also use `<br/>`, please also change them to make the doc consistent
   
   After looking for it, I only saw the metrics.md file, which is a table written by hand, and it was also modified.
   
   ## current
   <img width="1680" alt="image" src="https://user-images.githubusercontent.com/3898450/153446940-d8bd0f63-465c-4760-8370-fa52d0658212.png">
   
   ## fix
   <img width="1680" alt="image" src="https://user-images.githubusercontent.com/3898450/153446434-5dbef978-da6d-44b5-9b94-c5eebc6a1926.png">
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1890: [KYUUBI #1889] Improve the user experience of the configuration parameters of the document

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1890:
URL: https://github.com/apache/incubator-kyuubi/pull/1890#issuecomment-1034933285


   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1890?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1890](https://codecov.io/gh/apache/incubator-kyuubi/pull/1890?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2f9c7e0) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/b952b7b5d8d9ecc0a041bd91e1db8f20eb051495?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b952b7b) will **increase** coverage by `0.06%`.
   > The diff coverage is `n/a`.
   
   > :exclamation: Current head 2f9c7e0 differs from pull request most recent head abeb060. Consider uploading reports for the commit abeb060 to get more accurate results
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-kyuubi/pull/1890/graphs/tree.svg?width=650&height=150&src=pr&token=925D4tb9AH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-kyuubi/pull/1890?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1890      +/-   ##
   ============================================
   + Coverage     59.69%   59.75%   +0.06%     
   - Complexity      316      321       +5     
   ============================================
     Files           290      291       +1     
     Lines         14223    14234      +11     
     Branches       1804     1805       +1     
   ============================================
   + Hits           8490     8506      +16     
   + Misses         5009     5003       -6     
   - Partials        724      725       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1890?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...he/kyuubi/engine/trino/operation/GetCatalogs.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1890/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS10cmluby1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL3RyaW5vL29wZXJhdGlvbi9HZXRDYXRhbG9ncy5zY2FsYQ==) | `90.00% <0.00%> (ø)` | |
   | [...kyuubi/engine/trino/operation/TrinoOperation.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1890/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS10cmluby1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL3RyaW5vL29wZXJhdGlvbi9Ucmlub09wZXJhdGlvbi5zY2FsYQ==) | `49.01% <0.00%> (+9.80%)` | :arrow_up: |
   | [...engine/trino/operation/TrinoOperationManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1890/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS10cmluby1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL3RyaW5vL29wZXJhdGlvbi9Ucmlub09wZXJhdGlvbk1hbmFnZXIuc2NhbGE=) | `50.00% <0.00%> (+13.63%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1890?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1890?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b952b7b...abeb060](https://codecov.io/gh/apache/incubator-kyuubi/pull/1890?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] cxzl25 commented on pull request #1890: [KYUUBI #1889] Improve the user experience of the configuration parameters of the document

Posted by GitBox <gi...@apache.org>.
cxzl25 commented on pull request #1890:
URL: https://github.com/apache/incubator-kyuubi/pull/1890#issuecomment-1034897947


   ## current
   <img width="305" alt="image" src="https://user-images.githubusercontent.com/3898450/153413823-556e7741-87e8-4051-8a15-ac9bb4d17d62.png">
   
   
   ## fix
   <img width="1088" alt="image" src="https://user-images.githubusercontent.com/3898450/153413746-4b88e25f-3a27-4ea2-b41b-e68534a6dfa7.png">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] pan3793 commented on pull request #1890: [KYUUBI #1889] Improve the user experience of the configuration parameters of the document

Posted by GitBox <gi...@apache.org>.
pan3793 commented on pull request #1890:
URL: https://github.com/apache/incubator-kyuubi/pull/1890#issuecomment-1034900973


   Could you please give a full-page screenshot?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #1890: [KYUUBI #1889] Improve the user experience of the configuration parameters of the document

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1890:
URL: https://github.com/apache/incubator-kyuubi/pull/1890#issuecomment-1034933285


   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1890?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1890](https://codecov.io/gh/apache/incubator-kyuubi/pull/1890?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2f9c7e0) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/b952b7b5d8d9ecc0a041bd91e1db8f20eb051495?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b952b7b) will **increase** coverage by `0.06%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-kyuubi/pull/1890/graphs/tree.svg?width=650&height=150&src=pr&token=925D4tb9AH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-kyuubi/pull/1890?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1890      +/-   ##
   ============================================
   + Coverage     59.69%   59.75%   +0.06%     
   - Complexity      316      321       +5     
   ============================================
     Files           290      291       +1     
     Lines         14223    14234      +11     
     Branches       1804     1805       +1     
   ============================================
   + Hits           8490     8506      +16     
   + Misses         5009     5003       -6     
   - Partials        724      725       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1890?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...he/kyuubi/engine/trino/operation/GetCatalogs.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1890/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS10cmluby1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL3RyaW5vL29wZXJhdGlvbi9HZXRDYXRhbG9ncy5zY2FsYQ==) | `90.00% <0.00%> (ø)` | |
   | [...kyuubi/engine/trino/operation/TrinoOperation.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1890/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS10cmluby1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL3RyaW5vL29wZXJhdGlvbi9Ucmlub09wZXJhdGlvbi5zY2FsYQ==) | `49.01% <0.00%> (+9.80%)` | :arrow_up: |
   | [...engine/trino/operation/TrinoOperationManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1890/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS10cmluby1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL3RyaW5vL29wZXJhdGlvbi9Ucmlub09wZXJhdGlvbk1hbmFnZXIuc2NhbGE=) | `50.00% <0.00%> (+13.63%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1890?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1890?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b952b7b...2f9c7e0](https://codecov.io/gh/apache/incubator-kyuubi/pull/1890?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1890: [KYUUBI #1889] Improve the user experience of the configuration parameters of the document

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1890:
URL: https://github.com/apache/incubator-kyuubi/pull/1890#issuecomment-1034933285


   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1890?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1890](https://codecov.io/gh/apache/incubator-kyuubi/pull/1890?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2f9c7e0) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/b952b7b5d8d9ecc0a041bd91e1db8f20eb051495?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b952b7b) will **increase** coverage by `0.06%`.
   > The diff coverage is `n/a`.
   
   > :exclamation: Current head 2f9c7e0 differs from pull request most recent head 28865ad. Consider uploading reports for the commit 28865ad to get more accurate results
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-kyuubi/pull/1890/graphs/tree.svg?width=650&height=150&src=pr&token=925D4tb9AH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-kyuubi/pull/1890?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1890      +/-   ##
   ============================================
   + Coverage     59.69%   59.75%   +0.06%     
   - Complexity      316      321       +5     
   ============================================
     Files           290      291       +1     
     Lines         14223    14234      +11     
     Branches       1804     1805       +1     
   ============================================
   + Hits           8490     8506      +16     
   + Misses         5009     5003       -6     
   - Partials        724      725       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1890?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...he/kyuubi/engine/trino/operation/GetCatalogs.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1890/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS10cmluby1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL3RyaW5vL29wZXJhdGlvbi9HZXRDYXRhbG9ncy5zY2FsYQ==) | `90.00% <0.00%> (ø)` | |
   | [...kyuubi/engine/trino/operation/TrinoOperation.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1890/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS10cmluby1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL3RyaW5vL29wZXJhdGlvbi9Ucmlub09wZXJhdGlvbi5zY2FsYQ==) | `49.01% <0.00%> (+9.80%)` | :arrow_up: |
   | [...engine/trino/operation/TrinoOperationManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1890/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS10cmluby1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL3RyaW5vL29wZXJhdGlvbi9Ucmlub09wZXJhdGlvbk1hbmFnZXIuc2NhbGE=) | `50.00% <0.00%> (+13.63%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1890?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1890?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b952b7b...28865ad](https://codecov.io/gh/apache/incubator-kyuubi/pull/1890?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] cxzl25 commented on pull request #1890: [KYUUBI #1889] Improve the user experience of the configuration parameters of the document

Posted by GitBox <gi...@apache.org>.
cxzl25 commented on pull request #1890:
URL: https://github.com/apache/incubator-kyuubi/pull/1890#issuecomment-1035095817


   > I remember there are other places in `docs/` also use `<br/>`, please also change them to make the doc consistent
   
   After looking for it, I only saw the metrics.md file, which is a table written by hand, and it was also modified.
   
   <img width="1680" alt="image" src="https://user-images.githubusercontent.com/3898450/153446434-5dbef978-da6d-44b5-9b94-c5eebc6a1926.png">
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] cxzl25 edited a comment on pull request #1890: [KYUUBI #1889] Improve the user experience of the configuration parameters of the document

Posted by GitBox <gi...@apache.org>.
cxzl25 edited a comment on pull request #1890:
URL: https://github.com/apache/incubator-kyuubi/pull/1890#issuecomment-1034897947


   ## current
   <img width="1047" alt="image" src="https://user-images.githubusercontent.com/3898450/153418030-6917311c-5dcf-4a4d-9977-f2a67b1b8c25.png">
   
   
   ## fix
   <img width="1096" alt="image" src="https://user-images.githubusercontent.com/3898450/153418060-ba520a42-2763-463f-8469-fd70501a1a1f.png">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] cxzl25 commented on pull request #1890: [KYUUBI #1889] Improve the user experience of the configuration parameters of the document

Posted by GitBox <gi...@apache.org>.
cxzl25 commented on pull request #1890:
URL: https://github.com/apache/incubator-kyuubi/pull/1890#issuecomment-1035082894


   Now I increased the max-width of the content to avoid the horizontal scrollbar.
   
   <img width="1680" alt="image" src="https://user-images.githubusercontent.com/3898450/153444528-021f893b-4124-4ca0-a66c-15fad4943c46.png">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] ulysses-you commented on pull request #1890: [KYUUBI #1889] Improve the user experience of the configuration parameters of the document

Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #1890:
URL: https://github.com/apache/incubator-kyuubi/pull/1890#issuecomment-1035703274


   great improvement ! merging to master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] ulysses-you closed pull request #1890: [KYUUBI #1889] Improve the user experience of the configuration parameters of the document

Posted by GitBox <gi...@apache.org>.
ulysses-you closed pull request #1890:
URL: https://github.com/apache/incubator-kyuubi/pull/1890


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org