You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/04/01 06:07:21 UTC
[GitHub] [incubator-superset] datability-io opened a new pull request #7188:
fix: deck.gl polygon tooltip
datability-io opened a new pull request #7188: fix: deck.gl polygon tooltip
URL: https://github.com/apache/incubator-superset/pull/7188
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
##### SUMMARY
This PR fixes the `deck.gl Polygon` chart tooltip having issues when the underlying data range is less than 1. This PR also change the legend to use squares to align w/ tooltips used by other charts.
##### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before
![image](https://user-images.githubusercontent.com/17309187/55306588-a0c1b900-5409-11e9-9a9f-1dacff96ad9f.png)
After:
![image](https://user-images.githubusercontent.com/17309187/55306558-88ea3500-5409-11e9-8560-d7d30de174e9.png)
##### TEST PLAN
Eyeball
##### ADDITIONAL INFORMATION
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
<!--- Check any relevant boxes with "x" -->
[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration. Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API
[ ] Fixes bug
[ ] Refactors code
[ ] Adds test(s)
##### REVIEWERS
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org