You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Voloshanenko Igor <ig...@gmail.com> on 2017/12/20 00:59:46 UTC

PrivateGateaway ACL rules blocker

Hi all!

Guys, can i please kindly ask you to review this issue and PR -
https://issues.apache.org/jira/browse/CLOUDSTACK-10200

We have a lot of clients with PG and want to include this in 4.11 LTS as
without this small one-liner patch PrivateGateway component useless

Tnx in advance!

Re: PrivateGateaway ACL rules blocker

Posted by Voloshanenko Igor <ig...@gmail.com>.
Test passed.
So will wait till your guys will have time to review this one-liner and
merge it )

2017-12-20 14:16 GMT+02:00 Rohit Yadav <ro...@shapeblue.com>:

> Sure, I've kicked some tests. Will merge when tests pass and we've some
> review/feedback from others.
>
>
> -Rohit
>
> ________________________________
> From: Voloshanenko Igor <ig...@gmail.com>
> Sent: Wednesday, December 20, 2017 5:33:10 PM
> To: dev@cloudstack.apache.org
> Subject: Re: PrivateGateaway ACL rules blocker
>
> Tnx a lot Rohit!
>
> As we only handle a special case - I think all tests will pass without any
> issues. As I can't imagine that somebody assumed inside test to check if
> buggy condition passed :D
>
> 2017-12-20 13:02 GMT+02:00 Rohit Yadav <ro...@shapeblue.com>:
>
> > Hi Voloshanenko,
> >
> >
> > Thanks for reporting and sharing, I'll kick some tests.
> >
> >
> > - Rohit
> >
> > ________________________________
> > From: Voloshanenko Igor <ig...@gmail.com>
> > Sent: Wednesday, December 20, 2017 6:29:46 AM
> > To: dev@cloudstack.apache.org
> > Subject: PrivateGateaway ACL rules blocker
> >
> > Hi all!
> >
> > Guys, can i please kindly ask you to review this issue and PR -
> > https://issues.apache.org/jira/browse/CLOUDSTACK-10200
> >
> > We have a lot of clients with PG and want to include this in 4.11 LTS as
> > without this small one-liner patch PrivateGateway component useless
> >
> > Tnx in advance!
> >
> > rohit.yadav@shapeblue.com
> > www.shapeblue.com<http://www.shapeblue.com>
> > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> > @shapeblue
> >
> >
> >
> >
>
> rohit.yadav@shapeblue.com
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> @shapeblue
>
>
>
>

Re: PrivateGateaway ACL rules blocker

Posted by Rohit Yadav <ro...@shapeblue.com>.
Sure, I've kicked some tests. Will merge when tests pass and we've some review/feedback from others.


-Rohit

________________________________
From: Voloshanenko Igor <ig...@gmail.com>
Sent: Wednesday, December 20, 2017 5:33:10 PM
To: dev@cloudstack.apache.org
Subject: Re: PrivateGateaway ACL rules blocker

Tnx a lot Rohit!

As we only handle a special case - I think all tests will pass without any
issues. As I can't imagine that somebody assumed inside test to check if
buggy condition passed :D

2017-12-20 13:02 GMT+02:00 Rohit Yadav <ro...@shapeblue.com>:

> Hi Voloshanenko,
>
>
> Thanks for reporting and sharing, I'll kick some tests.
>
>
> - Rohit
>
> ________________________________
> From: Voloshanenko Igor <ig...@gmail.com>
> Sent: Wednesday, December 20, 2017 6:29:46 AM
> To: dev@cloudstack.apache.org
> Subject: PrivateGateaway ACL rules blocker
>
> Hi all!
>
> Guys, can i please kindly ask you to review this issue and PR -
> https://issues.apache.org/jira/browse/CLOUDSTACK-10200
>
> We have a lot of clients with PG and want to include this in 4.11 LTS as
> without this small one-liner patch PrivateGateway component useless
>
> Tnx in advance!
>
> rohit.yadav@shapeblue.com
> www.shapeblue.com<http://www.shapeblue.com>
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> @shapeblue
>
>
>
>

rohit.yadav@shapeblue.comĀ 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue
  
 


Re: PrivateGateaway ACL rules blocker

Posted by Voloshanenko Igor <ig...@gmail.com>.
Tnx a lot Rohit!

As we only handle a special case - I think all tests will pass without any
issues. As I can't imagine that somebody assumed inside test to check if
buggy condition passed :D

2017-12-20 13:02 GMT+02:00 Rohit Yadav <ro...@shapeblue.com>:

> Hi Voloshanenko,
>
>
> Thanks for reporting and sharing, I'll kick some tests.
>
>
> - Rohit
>
> ________________________________
> From: Voloshanenko Igor <ig...@gmail.com>
> Sent: Wednesday, December 20, 2017 6:29:46 AM
> To: dev@cloudstack.apache.org
> Subject: PrivateGateaway ACL rules blocker
>
> Hi all!
>
> Guys, can i please kindly ask you to review this issue and PR -
> https://issues.apache.org/jira/browse/CLOUDSTACK-10200
>
> We have a lot of clients with PG and want to include this in 4.11 LTS as
> without this small one-liner patch PrivateGateway component useless
>
> Tnx in advance!
>
> rohit.yadav@shapeblue.com
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> @shapeblue
>
>
>
>

Re: PrivateGateaway ACL rules blocker

Posted by Rohit Yadav <ro...@shapeblue.com>.
Hi Voloshanenko,


Thanks for reporting and sharing, I'll kick some tests.


- Rohit

________________________________
From: Voloshanenko Igor <ig...@gmail.com>
Sent: Wednesday, December 20, 2017 6:29:46 AM
To: dev@cloudstack.apache.org
Subject: PrivateGateaway ACL rules blocker

Hi all!

Guys, can i please kindly ask you to review this issue and PR -
https://issues.apache.org/jira/browse/CLOUDSTACK-10200

We have a lot of clients with PG and want to include this in 4.11 LTS as
without this small one-liner patch PrivateGateway component useless

Tnx in advance!

rohit.yadav@shapeblue.comĀ 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue