You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/02/23 07:05:15 UTC
[GitHub] [apisix-go-plugin-runner] rampagecong opened a new pull request #68: feat: add `rewrite:RespHeaders` and modify the upstream response ers via `request` implementation
rampagecong opened a new pull request #68:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/68
## This submission is modified as follows:
### 1.Add ```respHdr``` and ```RespHeader``` method to ```Request``` struct.
### 2.The ```Request FetchChanges``` method is modified.
### 3.Add and modify some test cases
This is refer to https://github.com/apache/apisix-go-plugin-runner/issues/67
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-go-plugin-runner] spacewander commented on pull request #68: feat: add `rewrite:RespHeaders` and modify the upstream response ers via `request` implementation
Posted by GitBox <gi...@apache.org>.
spacewander commented on pull request #68:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/68#issuecomment-1060122431
Need to resolve conflicts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-go-plugin-runner] shuaijinchao merged pull request #68: feat: add `rewrite:RespHeaders` and modify the upstream response ers via `request` implementation
Posted by GitBox <gi...@apache.org>.
shuaijinchao merged pull request #68:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/68
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-go-plugin-runner] codecov-commenter edited a comment on pull request #68: feat: add `rewrite:RespHeaders` and modify the upstream response ers via `request` implementation
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #68:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/68#issuecomment-1060124276
# [Codecov](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/68?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#68](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/68?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f4d194a) into [master](https://codecov.io/gh/apache/apisix-go-plugin-runner/commit/ade2e90be694adedda2bbeed48708e727b1cb11d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ade2e90) will **decrease** coverage by `1.14%`.
> The diff coverage is `96.00%`.
[](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/68?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #68 +/- ##
==========================================
- Coverage 80.60% 79.46% -1.15%
==========================================
Files 11 11
Lines 722 745 +23
==========================================
+ Hits 582 592 +10
- Misses 102 114 +12
- Partials 38 39 +1
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/68?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [internal/http/request.go](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/68/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvaHR0cC9yZXF1ZXN0Lmdv) | `93.46% <96.00%> (+0.67%)` | :arrow_up: |
| [internal/server/server.go](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/68/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvc2VydmVyL3NlcnZlci5nbw==) | `56.91% <0.00%> (-10.57%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/68?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/68?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ade2e90...f4d194a](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/68?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-go-plugin-runner] codecov-commenter edited a comment on pull request #68: feat: add `rewrite:RespHeaders` and modify the upstream response ers via `request` implementation
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #68:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/68#issuecomment-1060124276
# [Codecov](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/68?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#68](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/68?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (24381ca) into [master](https://codecov.io/gh/apache/apisix-go-plugin-runner/commit/ade2e90be694adedda2bbeed48708e727b1cb11d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ade2e90) will **decrease** coverage by `2.19%`.
> The diff coverage is `96.15%`.
> :exclamation: Current head 24381ca differs from pull request most recent head 95a790f. Consider uploading reports for the commit 95a790f to get more accurate results
[](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/68?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #68 +/- ##
==========================================
- Coverage 80.60% 78.41% -2.20%
==========================================
Files 11 11
Lines 722 746 +24
==========================================
+ Hits 582 585 +3
- Misses 102 122 +20
- Partials 38 39 +1
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/68?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [internal/http/request.go](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/68/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvaHR0cC9yZXF1ZXN0Lmdv) | `93.49% <96.15%> (+0.70%)` | :arrow_up: |
| [internal/server/server.go](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/68/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvc2VydmVyL3NlcnZlci5nbw==) | `50.40% <0.00%> (-17.08%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/68?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/68?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ade2e90...95a790f](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/68?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-go-plugin-runner] rampagecong commented on pull request #68: feat: add `rewrite:RespHeaders` and modify the upstream response ers via `request` implementation
Posted by GitBox <gi...@apache.org>.
rampagecong commented on pull request #68:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/68#issuecomment-1061486284
Hello,Please run CI again.
@spacewander
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-go-plugin-runner] spacewander commented on pull request #68: feat: add `rewrite:RespHeaders` and modify the upstream response ers via `request` implementation
Posted by GitBox <gi...@apache.org>.
spacewander commented on pull request #68:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/68#issuecomment-1060112360
Sorry for my delay. Could you make the CI pass?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-go-plugin-runner] codecov-commenter commented on pull request #68: feat: add `rewrite:RespHeaders` and modify the upstream response ers via `request` implementation
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #68:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/68#issuecomment-1060124276
# [Codecov](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/68?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#68](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/68?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a3dad93) into [master](https://codecov.io/gh/apache/apisix-go-plugin-runner/commit/ade2e90be694adedda2bbeed48708e727b1cb11d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ade2e90) will **decrease** coverage by `1.14%`.
> The diff coverage is `96.00%`.
[](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/68?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #68 +/- ##
==========================================
- Coverage 80.60% 79.46% -1.15%
==========================================
Files 11 11
Lines 722 745 +23
==========================================
+ Hits 582 592 +10
- Misses 102 114 +12
- Partials 38 39 +1
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/68?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [internal/http/request.go](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/68/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvaHR0cC9yZXF1ZXN0Lmdv) | `93.46% <96.00%> (+0.67%)` | :arrow_up: |
| [internal/server/server.go](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/68/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvc2VydmVyL3NlcnZlci5nbw==) | `56.91% <0.00%> (-10.57%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/68?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/68?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ade2e90...a3dad93](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/68?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-go-plugin-runner] spacewander commented on a change in pull request #68: feat: add `rewrite:RespHeaders` and modify the upstream response ers via `request` implementation
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #68:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/68#discussion_r820337351
##########
File path: pkg/http/http.go
##########
@@ -67,6 +67,9 @@ type Request interface {
//
// For run plugin, the context controls cancellation.
Context() context.Context
+ // RespHeader returns the response header
Review comment:
RespHeader returns an `http.Header` which allows you to add or set response headers before reaching the upstream.
Some built-in headers would not take effect, like ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-go-plugin-runner] rampagecong commented on pull request #68: feat: add `rewrite:RespHeaders` and modify the upstream response ers via `request` implementation
Posted by GitBox <gi...@apache.org>.
rampagecong commented on pull request #68:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/68#issuecomment-1060113954
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org