You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by "Mathias Bogaert (JIRA)" <ji...@apache.org> on 2008/12/15 10:39:44 UTC
[jira] Created: (SHINDIG-788) Use ImmutableSet.of in
DataRequestHandler
Use ImmutableSet.of in DataRequestHandler
-----------------------------------------
Key: SHINDIG-788
URL: https://issues.apache.org/jira/browse/SHINDIG-788
Project: Shindig
Issue Type: Improvement
Components: Common Components (Java)
Affects Versions: trunk, 1.0.0-rc1, 1.0.x-incubating
Reporter: Mathias Bogaert
Priority: Minor
Attachments: immutablesetof.patch
ImmutableSet.of is more performant than Sets.newHashSet. Patch attached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-788) Use ImmutableSet.of in
DataRequestHandler
Posted by "Mathias Bogaert (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mathias Bogaert updated SHINDIG-788:
------------------------------------
Attachment: immutablesetof.patch
> Use ImmutableSet.of in DataRequestHandler
> -----------------------------------------
>
> Key: SHINDIG-788
> URL: https://issues.apache.org/jira/browse/SHINDIG-788
> Project: Shindig
> Issue Type: Improvement
> Components: Common Components (Java)
> Affects Versions: trunk, 1.0.0-rc1, 1.0.x-incubating
> Reporter: Mathias Bogaert
> Priority: Minor
> Attachments: immutablesetof.patch
>
>
> ImmutableSet.of is more performant than Sets.newHashSet. Patch attached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-788) Use ImmutableSet.of in
DataRequestHandler
Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656968#action_12656968 ]
Paul Lindner commented on SHINDIG-788:
--------------------------------------
actually I didn't commit this until now...
Lots of changes/fixes here to effectively use google collections.
There's a lot more we could do. Specifically set intersection, union, and difference, and MultiMap, lots and lots of MultiMap.
> Use ImmutableSet.of in DataRequestHandler
> -----------------------------------------
>
> Key: SHINDIG-788
> URL: https://issues.apache.org/jira/browse/SHINDIG-788
> Project: Shindig
> Issue Type: Improvement
> Components: Common Components (Java)
> Affects Versions: trunk, 1.0.0-rc1, 1.0.x-incubating
> Reporter: Mathias Bogaert
> Assignee: Paul Lindner
> Priority: Minor
> Fix For: trunk
>
> Attachments: gc.patch, immutablesetof.patch
>
>
> ImmutableSet.of is more performant than Sets.newHashSet. Patch attached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (SHINDIG-788) Use ImmutableSet.of in
DataRequestHandler
Posted by "Kevin Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Brown closed SHINDIG-788.
-------------------------------
Resolution: Fixed
Fix Version/s: trunk
Assignee: Paul Lindner
Closing since Paul has committed the upgrade.
> Use ImmutableSet.of in DataRequestHandler
> -----------------------------------------
>
> Key: SHINDIG-788
> URL: https://issues.apache.org/jira/browse/SHINDIG-788
> Project: Shindig
> Issue Type: Improvement
> Components: Common Components (Java)
> Affects Versions: trunk, 1.0.0-rc1, 1.0.x-incubating
> Reporter: Mathias Bogaert
> Assignee: Paul Lindner
> Priority: Minor
> Fix For: trunk
>
> Attachments: gc.patch, immutablesetof.patch
>
>
> ImmutableSet.of is more performant than Sets.newHashSet. Patch attached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-788) Use ImmutableSet.of in
DataRequestHandler
Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656793#action_12656793 ]
Paul Lindner commented on SHINDIG-788:
--------------------------------------
I have 2500 line patch that adds google collections in all the right places and includes the changes in the patch you submitted.
I will apply this if no one objects...
> Use ImmutableSet.of in DataRequestHandler
> -----------------------------------------
>
> Key: SHINDIG-788
> URL: https://issues.apache.org/jira/browse/SHINDIG-788
> Project: Shindig
> Issue Type: Improvement
> Components: Common Components (Java)
> Affects Versions: trunk, 1.0.0-rc1, 1.0.x-incubating
> Reporter: Mathias Bogaert
> Priority: Minor
> Attachments: gc.patch, immutablesetof.patch
>
>
> ImmutableSet.of is more performant than Sets.newHashSet. Patch attached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-788) Use ImmutableSet.of in
DataRequestHandler
Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Lindner updated SHINDIG-788:
---------------------------------
Attachment: gc.patch
Google Collections everywhere...
> Use ImmutableSet.of in DataRequestHandler
> -----------------------------------------
>
> Key: SHINDIG-788
> URL: https://issues.apache.org/jira/browse/SHINDIG-788
> Project: Shindig
> Issue Type: Improvement
> Components: Common Components (Java)
> Affects Versions: trunk, 1.0.0-rc1, 1.0.x-incubating
> Reporter: Mathias Bogaert
> Priority: Minor
> Attachments: gc.patch, immutablesetof.patch
>
>
> ImmutableSet.of is more performant than Sets.newHashSet. Patch attached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-788) Use ImmutableSet.of in
DataRequestHandler
Posted by "Mathias Bogaert (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mathias Bogaert updated SHINDIG-788:
------------------------------------
Attachment: (was: immutablesetof.patch)
> Use ImmutableSet.of in DataRequestHandler
> -----------------------------------------
>
> Key: SHINDIG-788
> URL: https://issues.apache.org/jira/browse/SHINDIG-788
> Project: Shindig
> Issue Type: Improvement
> Components: Common Components (Java)
> Affects Versions: trunk, 1.0.0-rc1, 1.0.x-incubating
> Reporter: Mathias Bogaert
> Priority: Minor
> Attachments: immutablesetof.patch
>
>
> ImmutableSet.of is more performant than Sets.newHashSet. Patch attached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.