[GitHub] [geode-benchmarks] balesh2 opened pull request #119: Confirm and retry AWS instance allocations.

["balesh2 (GitHub)" <gi...@apache.org>]

Retry with timeouts, confirming the expected number of instances have
been allocated.

Retry with timeouts, confirming the expected number of instances are in
the running state.

Signed-off-by: Robert Houghton <rh...@pivotal.io>

[ Full content available at: https://github.com/apache/geode-benchmarks/pull/119 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-benchmarks] DonalEvans commented on pull request #119: Confirm and retry AWS instance allocations.

["DonalEvans (GitHub)" <gi...@apache.org>]

Should this loop have a `sleep(AwsBenchmarkMetadata.POLL_INTERVAL);` line similar to the `waitForInstances()` method?

[ Full content available at: https://github.com/apache/geode-benchmarks/pull/119 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-benchmarks] balesh2 commented on pull request #119: Confirm and retry AWS instance allocations.

["balesh2 (GitHub)" <gi...@apache.org>]

It could have one but doesn't need it. The reason we have that in the other loop is that the loop is waiting for the instances to become available, so there's no point in checking constantly. In this loop, the allocateHosts call is blocking, so that keeps this from being a hot loop.

[ Full content available at: https://github.com/apache/geode-benchmarks/pull/119 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-benchmarks] balesh2 closed pull request #119: Confirm and retry AWS instance allocations.

["balesh2 (GitHub)" <gi...@apache.org>]

[ pull request closed by balesh2 ]

[ Full content available at: https://github.com/apache/geode-benchmarks/pull/119 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org