[GitHub] [spark] maziyarpanahi commented on a diff in pull request #42382: [ML] Remove usage of RDD APIs for load/save in spark-ml

["maziyarpanahi (via GitHub)" <gi...@apache.org>]

maziyarpanahi commented on code in PR #42382:
URL: https://github.com/apache/spark/pull/42382#discussion_r1330333290


##########
mllib/src/main/scala/org/apache/spark/ml/util/ReadWrite.scala:
##########
@@ -405,12 +405,14 @@ private[ml] object DefaultParamsWriter {
   def saveMetadata(
       instance: Params,
       path: String,
-      sc: SparkContext,

Review Comment:
   @srowen @WeichenXu123 I would appreciate it if, as we move towards Spark 4.0, we could all consider the compatibility of third-party libraries beyond those that Databricks plans to deprecate



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org