You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Gabriel39 (via GitHub)" <gi...@apache.org> on 2024/06/11 02:33:16 UTC
[PR] [fix](memory) Refactor memory allocated failure processing [doris]
Gabriel39 opened a new pull request, #36090:
URL: https://github.com/apache/doris/pull/36090
## Proposed changes
Issue Number: close #xxx
<!--Describe your changes.-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](memory) Refactor memory allocated failure processing [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36090:
URL: https://github.com/apache/doris/pull/36090#issuecomment-2159669668
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](memory) Refactor memory allocated failure processing [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36090:
URL: https://github.com/apache/doris/pull/36090#issuecomment-2162028573
<details>
<summary>ClickBench: <b>Total hot run time: 31.36 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d8dcfdb7ceda7d76169c22e7ffa33e7f79920f7f, data reload: false
query1 0.04 0.03 0.04
query2 0.07 0.04 0.04
query3 0.23 0.05 0.06
query4 1.68 0.09 0.09
query5 0.50 0.49 0.48
query6 1.14 0.72 0.73
query7 0.02 0.01 0.01
query8 0.05 0.04 0.05
query9 0.54 0.47 0.47
query10 0.53 0.52 0.54
query11 0.16 0.11 0.12
query12 0.14 0.11 0.12
query13 0.59 0.59 0.60
query14 0.77 0.77 0.80
query15 0.82 0.83 0.81
query16 0.37 0.37 0.36
query17 1.00 1.04 1.05
query18 0.21 0.26 0.24
query19 1.79 1.77 1.79
query20 0.02 0.01 0.01
query21 15.42 0.66 0.66
query22 4.08 6.46 2.52
query23 18.34 1.36 1.25
query24 1.86 0.27 0.24
query25 0.16 0.09 0.08
query26 0.27 0.17 0.17
query27 0.08 0.08 0.08
query28 13.20 1.00 1.00
query29 12.59 3.40 3.40
query30 0.26 0.06 0.06
query31 2.86 0.38 0.38
query32 3.33 0.47 0.46
query33 2.97 2.92 2.89
query34 16.97 4.49 4.40
query35 4.52 4.47 4.51
query36 0.66 0.47 0.46
query37 0.18 0.16 0.16
query38 0.16 0.14 0.14
query39 0.04 0.03 0.03
query40 0.18 0.15 0.14
query41 0.10 0.05 0.04
query42 0.05 0.05 0.04
query43 0.04 0.03 0.04
Total cold run time: 108.99 s
Total hot run time: 31.36 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](memory) Refactor memory allocated failure processing [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36090:
URL: https://github.com/apache/doris/pull/36090#issuecomment-2162064321
TeamCity be ut coverage result:
Function Coverage: 36.40% (8984/24681)
Line Coverage: 27.94% (73455/262866)
Region Coverage: 27.38% (38085/139096)
Branch Coverage: 24.00% (19340/80576)
Coverage Report: http://coverage.selectdb-in.cc/coverage/d8dcfdb7ceda7d76169c22e7ffa33e7f79920f7f_d8dcfdb7ceda7d76169c22e7ffa33e7f79920f7f/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](memory) Refactor memory allocated failure processing [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36090:
URL: https://github.com/apache/doris/pull/36090#issuecomment-2159754308
<details>
<summary>ClickBench: <b>Total hot run time: 31.17 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 5a5502f357e1fe303f3c87800ac5c93644f39f92, data reload: false
query1 0.04 0.04 0.03
query2 0.08 0.04 0.04
query3 0.22 0.05 0.05
query4 1.69 0.07 0.08
query5 0.51 0.50 0.47
query6 1.14 0.74 0.73
query7 0.02 0.02 0.01
query8 0.05 0.04 0.05
query9 0.53 0.50 0.50
query10 0.55 0.57 0.54
query11 0.16 0.11 0.12
query12 0.15 0.12 0.12
query13 0.59 0.58 0.60
query14 0.79 0.78 0.77
query15 0.83 0.81 0.81
query16 0.36 0.36 0.36
query17 0.96 1.02 1.01
query18 0.23 0.26 0.24
query19 1.87 1.75 1.74
query20 0.02 0.01 0.01
query21 15.42 0.66 0.66
query22 3.63 7.59 2.29
query23 18.32 1.34 1.26
query24 2.08 0.23 0.22
query25 0.15 0.09 0.09
query26 0.28 0.17 0.17
query27 0.08 0.08 0.08
query28 13.25 1.01 1.00
query29 12.63 3.28 3.26
query30 0.26 0.06 0.06
query31 2.86 0.41 0.39
query32 3.29 0.47 0.48
query33 2.93 2.84 2.95
query34 17.22 4.68 4.59
query35 4.78 4.62 4.51
query36 0.66 0.46 0.47
query37 0.18 0.15 0.15
query38 0.16 0.15 0.15
query39 0.05 0.04 0.03
query40 0.16 0.15 0.14
query41 0.09 0.04 0.05
query42 0.06 0.04 0.04
query43 0.04 0.04 0.04
Total cold run time: 109.37 s
Total hot run time: 31.17 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](memory) Refactor memory allocated failure processing [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36090:
URL: https://github.com/apache/doris/pull/36090#issuecomment-2162014476
<details>
<summary>TPC-H: <b>Total hot run time: 39970 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d8dcfdb7ceda7d76169c22e7ffa33e7f79920f7f, data reload: false
------ Round 1 ----------------------------------
q1 18771 4736 4389 4389
q2 3019 200 196 196
q3 10896 1123 1092 1092
q4 11210 892 766 766
q5 7498 2736 2698 2698
q6 229 145 140 140
q7 970 615 597 597
q8 9216 2075 2058 2058
q9 9003 6495 6483 6483
q10 8918 3705 3734 3705
q11 467 241 236 236
q12 394 225 223 223
q13 17802 2970 3040 2970
q14 266 224 210 210
q15 518 473 477 473
q16 517 388 377 377
q17 976 647 626 626
q18 8041 7481 7432 7432
q19 4513 1566 1414 1414
q20 650 308 337 308
q21 5039 3254 3284 3254
q22 390 323 330 323
Total cold run time: 119303 ms
Total hot run time: 39970 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4428 4286 4261 4261
q2 367 262 273 262
q3 2985 2767 2708 2708
q4 1876 1633 1639 1633
q5 5258 5265 5281 5265
q6 220 128 128 128
q7 2163 1758 1748 1748
q8 3164 3327 3324 3324
q9 8306 8321 8328 8321
q10 3901 3656 3692 3656
q11 599 480 477 477
q12 766 618 594 594
q13 16269 2971 2979 2971
q14 289 276 243 243
q15 508 479 481 479
q16 461 405 428 405
q17 1770 1481 1486 1481
q18 7663 7565 7344 7344
q19 1778 1490 1520 1490
q20 1989 1790 1760 1760
q21 4962 4674 4719 4674
q22 602 546 542 542
Total cold run time: 70324 ms
Total hot run time: 53766 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](memory) Refactor memory allocated failure processing [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36090:
URL: https://github.com/apache/doris/pull/36090#issuecomment-2159740572
<details>
<summary>TPC-H: <b>Total hot run time: 39722 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 5a5502f357e1fe303f3c87800ac5c93644f39f92, data reload: false
------ Round 1 ----------------------------------
q1 17600 4377 4410 4377
q2 2032 181 189 181
q3 10477 1160 1037 1037
q4 10193 738 907 738
q5 7487 2654 2615 2615
q6 219 138 135 135
q7 953 620 594 594
q8 9218 2262 2067 2067
q9 8924 6485 6442 6442
q10 8941 3809 3739 3739
q11 451 240 253 240
q12 427 226 219 219
q13 17770 2984 2977 2977
q14 261 224 217 217
q15 495 469 474 469
q16 503 394 366 366
q17 964 723 704 704
q18 8022 7578 7334 7334
q19 3284 1397 1479 1397
q20 663 328 308 308
q21 4932 3236 4013 3236
q22 393 336 330 330
Total cold run time: 114209 ms
Total hot run time: 39722 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4354 4229 4254 4229
q2 362 285 268 268
q3 3019 2778 2976 2778
q4 2006 1643 1641 1641
q5 5572 5551 5532 5532
q6 219 129 131 129
q7 2174 1825 1880 1825
q8 3368 3428 3404 3404
q9 8676 8646 8795 8646
q10 4109 3954 3810 3810
q11 584 481 492 481
q12 763 653 653 653
q13 15835 3168 3149 3149
q14 320 275 280 275
q15 531 473 492 473
q16 510 441 443 441
q17 1843 1505 1471 1471
q18 8131 7987 7869 7869
q19 1726 1655 1534 1534
q20 2055 1861 1922 1861
q21 5138 4897 4957 4897
q22 641 582 565 565
Total cold run time: 71936 ms
Total hot run time: 55931 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](memory) Refactor memory allocated failure processing [doris]
Posted by "xinyiZzz (via GitHub)" <gi...@apache.org>.
xinyiZzz commented on code in PR #36090:
URL: https://github.com/apache/doris/pull/36090#discussion_r1634887034
##########
be/src/runtime/fragment_mgr.cpp:
##########
@@ -718,7 +718,21 @@ Status FragmentMgr::exec_plan_fragment(const TPipelineFragmentParams& params,
this, std::placeholders::_1, std::placeholders::_2));
{
SCOPED_RAW_TIMER(&duration_ns);
- auto prepare_st = context->prepare(params);
+ Status prepare_st = Status::OK();
+ try {
+ doris::enable_thread_catch_bad_alloc++;
+ Defer defer {[&]() { doris::enable_thread_catch_bad_alloc--; }};
Review Comment:
Status st = RETURN_IF_CATCH_EXCEPTION(context->prepare(params));
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](memory) Refactor memory allocated failure processing [doris]
Posted by "Gabriel39 (via GitHub)" <gi...@apache.org>.
Gabriel39 commented on PR #36090:
URL: https://github.com/apache/doris/pull/36090#issuecomment-2161996370
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](memory) Refactor memory allocated failure processing [doris]
Posted by "xinyiZzz (via GitHub)" <gi...@apache.org>.
xinyiZzz commented on code in PR #36090:
URL: https://github.com/apache/doris/pull/36090#discussion_r1634894277
##########
be/src/pipeline/task_scheduler.cpp:
##########
@@ -128,6 +128,8 @@ void TaskScheduler::_do_work(size_t index) {
auto status = Status::OK();
try {
+ doris::enable_thread_catch_bad_alloc++;
+ Defer defer {[&]() { doris::enable_thread_catch_bad_alloc--; }};
Review Comment:
status = RETURN_IF_CATCH_EXCEPTION(
{//TODO: use a better enclose to abstracting these
if (ExecEnv::GetInstance()->pipeline_tracer_context()->enabled()) {
TUniqueId query_id = task->query_context()->query_id();
status = task->execute(&eos);
}});
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](memory) Refactor memory allocated failure processing [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36090:
URL: https://github.com/apache/doris/pull/36090#issuecomment-2162023726
<details>
<summary>TPC-DS: <b>Total hot run time: 173411 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d8dcfdb7ceda7d76169c22e7ffa33e7f79920f7f, data reload: false
query1 934 376 375 375
query2 6469 2425 2299 2299
query3 6647 224 217 217
query4 19642 17253 17347 17253
query5 4208 471 468 468
query6 253 176 161 161
query7 4586 310 288 288
query8 306 281 280 280
query9 8488 2372 2343 2343
query10 596 304 291 291
query11 10468 9908 9979 9908
query12 136 89 83 83
query13 1661 366 364 364
query14 9445 7804 7627 7627
query15 237 195 196 195
query16 7204 277 275 275
query17 1874 585 582 582
query18 1833 292 280 280
query19 211 161 158 158
query20 95 84 85 84
query21 213 140 129 129
query22 4328 4069 3937 3937
query23 33720 33257 33118 33118
query24 11683 2844 2856 2844
query25 675 390 387 387
query26 1470 158 164 158
query27 2754 324 323 323
query28 7156 2034 2031 2031
query29 962 646 633 633
query30 291 153 157 153
query31 947 755 754 754
query32 94 61 59 59
query33 779 311 295 295
query34 918 476 492 476
query35 731 678 619 619
query36 1092 921 919 919
query37 158 73 74 73
query38 2941 2722 2739 2722
query39 869 806 806 806
query40 283 129 131 129
query41 57 52 50 50
query42 124 100 103 100
query43 598 553 550 550
query44 1215 738 748 738
query45 195 166 161 161
query46 1090 772 729 729
query47 1859 1760 1783 1760
query48 381 302 333 302
query49 1111 406 415 406
query50 767 386 391 386
query51 6763 6715 6597 6597
query52 103 102 92 92
query53 355 294 290 290
query54 962 442 444 442
query55 78 74 75 74
query56 284 262 276 262
query57 1108 1069 1053 1053
query58 259 245 274 245
query59 3344 3085 3071 3071
query60 297 269 279 269
query61 91 92 89 89
query62 655 429 445 429
query63 325 295 290 290
query64 9981 2224 1732 1732
query65 3190 3129 3065 3065
query66 1383 346 334 334
query67 15488 15046 14849 14849
query68 5772 547 542 542
query69 620 443 407 407
query70 1205 1157 1123 1123
query71 459 319 267 267
query72 7213 5700 5333 5333
query73 794 334 327 327
query74 5925 5499 5484 5484
query75 3874 2677 2694 2677
query76 3633 919 962 919
query77 648 314 303 303
query78 10301 9884 9841 9841
query79 2094 521 520 520
query80 1852 467 481 467
query81 568 217 217 217
query82 1432 107 105 105
query83 270 168 169 168
query84 266 87 89 87
query85 1538 280 265 265
query86 478 295 307 295
query87 3287 3102 3130 3102
query88 3913 2441 2443 2441
query89 477 386 396 386
query90 1815 194 196 194
query91 134 97 96 96
query92 64 49 49 49
query93 2187 506 511 506
query94 1227 189 185 185
query95 398 312 331 312
query96 597 270 270 270
query97 3225 3036 3055 3036
query98 214 201 200 200
query99 1249 865 826 826
Total cold run time: 277149 ms
Total hot run time: 173411 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](memory) Refactor memory allocated failure processing [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36090:
URL: https://github.com/apache/doris/pull/36090#issuecomment-2162023804
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](memory) Refactor memory allocated failure processing [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36090:
URL: https://github.com/apache/doris/pull/36090#issuecomment-2159657361
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](memory) Refactor memory allocated failure processing [doris]
Posted by "xinyiZzz (via GitHub)" <gi...@apache.org>.
xinyiZzz commented on code in PR #36090:
URL: https://github.com/apache/doris/pull/36090#discussion_r1634814651
##########
be/src/vec/exec/scan/scanner_scheduler.cpp:
##########
@@ -221,70 +221,85 @@ void ScannerScheduler::_scanner_scan(std::shared_ptr<ScannerContext> ctx,
scanner->start_scan_cpu_timer();
Status status = Status::OK();
bool eos = false;
- RuntimeState* state = ctx->state();
- DCHECK(nullptr != state);
- if (!scanner->is_init()) {
- status = scanner->init();
- if (!status.ok()) {
- eos = true;
+ try {
+ doris::enable_thread_catch_bad_alloc++;
+ Defer defer {[&]() { doris::enable_thread_catch_bad_alloc--; }};
Review Comment:
use a macro package `try catch`, easier to maintenance
##########
be/src/pipeline/task_scheduler.cpp:
##########
@@ -128,6 +128,8 @@ void TaskScheduler::_do_work(size_t index) {
auto status = Status::OK();
try {
+ doris::enable_thread_catch_bad_alloc++;
+ Defer defer {[&]() { doris::enable_thread_catch_bad_alloc--; }};
Review Comment:
use a macro package `try catch`, easier to maintenance
##########
be/src/runtime/fragment_mgr.cpp:
##########
@@ -718,7 +718,21 @@ Status FragmentMgr::exec_plan_fragment(const TPipelineFragmentParams& params,
this, std::placeholders::_1, std::placeholders::_2));
{
SCOPED_RAW_TIMER(&duration_ns);
- auto prepare_st = context->prepare(params);
+ Status prepare_st = Status::OK();
+ try {
+ doris::enable_thread_catch_bad_alloc++;
+ Defer defer {[&]() { doris::enable_thread_catch_bad_alloc--; }};
Review Comment:
use a macro package `try catch`, easier to maintenance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](memory) Refactor memory allocated failure processing [doris]
Posted by "Gabriel39 (via GitHub)" <gi...@apache.org>.
Gabriel39 merged PR #36090:
URL: https://github.com/apache/doris/pull/36090
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](memory) Refactor memory allocated failure processing [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36090:
URL: https://github.com/apache/doris/pull/36090#issuecomment-2159749971
<details>
<summary>TPC-DS: <b>Total hot run time: 173982 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 5a5502f357e1fe303f3c87800ac5c93644f39f92, data reload: false
query1 927 383 370 370
query2 6577 2487 2432 2432
query3 6721 208 206 206
query4 18868 17402 17203 17203
query5 3570 479 472 472
query6 242 164 165 164
query7 4586 295 297 295
query8 318 304 308 304
query9 8449 2392 2368 2368
query10 557 302 295 295
query11 10451 9951 10051 9951
query12 124 87 82 82
query13 1623 373 363 363
query14 10145 7185 7654 7185
query15 224 190 189 189
query16 7688 261 259 259
query17 1924 546 503 503
query18 1799 280 286 280
query19 188 153 151 151
query20 91 83 85 83
query21 204 131 130 130
query22 4393 3952 3982 3952
query23 33901 33699 33817 33699
query24 11001 2906 2919 2906
query25 624 424 376 376
query26 883 165 168 165
query27 2383 326 336 326
query28 6438 2126 2104 2104
query29 871 625 642 625
query30 248 155 167 155
query31 976 773 758 758
query32 94 62 55 55
query33 756 292 282 282
query34 1066 527 470 470
query35 749 624 715 624
query36 1115 941 943 941
query37 137 69 74 69
query38 3017 2861 2838 2838
query39 886 863 843 843
query40 225 138 128 128
query41 55 52 51 51
query42 116 107 107 107
query43 609 578 585 578
query44 1190 729 737 729
query45 194 161 165 161
query46 1071 728 729 728
query47 1827 1738 1794 1738
query48 385 299 295 295
query49 836 404 415 404
query50 759 394 394 394
query51 6835 6672 6685 6672
query52 101 96 92 92
query53 370 295 296 295
query54 890 458 447 447
query55 77 76 77 76
query56 306 281 277 277
query57 1095 999 1041 999
query58 266 246 255 246
query59 3514 3291 3295 3291
query60 297 269 272 269
query61 89 108 92 92
query62 624 449 458 449
query63 319 302 305 302
query64 8814 2194 1718 1718
query65 3233 3106 3106 3106
query66 740 318 376 318
query67 15408 15153 14826 14826
query68 4503 548 547 547
query69 451 318 315 315
query70 1190 1154 1195 1154
query71 403 277 280 277
query72 7077 5516 5439 5439
query73 744 324 321 321
query74 5920 5487 5508 5487
query75 3366 2721 2656 2656
query76 2256 967 923 923
query77 428 316 303 303
query78 10418 9727 9949 9727
query79 2225 523 514 514
query80 1074 481 464 464
query81 597 221 228 221
query82 734 107 108 107
query83 231 165 164 164
query84 231 90 83 83
query85 1795 280 272 272
query86 485 338 301 301
query87 3235 3072 3119 3072
query88 4341 2355 2377 2355
query89 478 392 451 392
query90 1721 192 185 185
query91 126 100 99 99
query92 60 48 50 48
query93 2462 510 497 497
query94 1078 188 187 187
query95 398 308 317 308
query96 610 265 266 265
query97 3238 3026 3038 3026
query98 224 197 191 191
query99 1305 821 835 821
Total cold run time: 268463 ms
Total hot run time: 173982 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](memory) Refactor memory allocated failure processing [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36090:
URL: https://github.com/apache/doris/pull/36090#issuecomment-2159751529
TeamCity be ut coverage result:
Function Coverage: 36.43% (8974/24634)
Line Coverage: 27.96% (73347/262325)
Region Coverage: 27.38% (38006/138811)
Branch Coverage: 23.99% (19301/80444)
Coverage Report: http://coverage.selectdb-in.cc/coverage/5a5502f357e1fe303f3c87800ac5c93644f39f92_5a5502f357e1fe303f3c87800ac5c93644f39f92/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](memory) Refactor memory allocated failure processing [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36090:
URL: https://github.com/apache/doris/pull/36090#issuecomment-2161995208
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](memory) Refactor memory allocated failure processing [doris]
Posted by "xinyiZzz (via GitHub)" <gi...@apache.org>.
xinyiZzz commented on code in PR #36090:
URL: https://github.com/apache/doris/pull/36090#discussion_r1634887034
##########
be/src/runtime/fragment_mgr.cpp:
##########
@@ -718,7 +718,21 @@ Status FragmentMgr::exec_plan_fragment(const TPipelineFragmentParams& params,
this, std::placeholders::_1, std::placeholders::_2));
{
SCOPED_RAW_TIMER(&duration_ns);
- auto prepare_st = context->prepare(params);
+ Status prepare_st = Status::OK();
+ try {
+ doris::enable_thread_catch_bad_alloc++;
+ Defer defer {[&]() { doris::enable_thread_catch_bad_alloc--; }};
Review Comment:
Status prepare_st = RETURN_IF_CATCH_EXCEPTION(context->prepare(params));
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](memory) Refactor memory allocated failure processing [doris]
Posted by "Gabriel39 (via GitHub)" <gi...@apache.org>.
Gabriel39 commented on PR #36090:
URL: https://github.com/apache/doris/pull/36090#issuecomment-2159692703
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](memory) Refactor memory allocated failure processing [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36090:
URL: https://github.com/apache/doris/pull/36090#issuecomment-2161993535
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](memory) Refactor memory allocated failure processing [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36090:
URL: https://github.com/apache/doris/pull/36090#issuecomment-2162023766
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org