You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "elharo (via GitHub)" <gi...@apache.org> on 2026/08/03 13:35:57 UTC

[PR] fix(classes): keep inner class references ($) from UTF-8 pool in ImportVisitor [maven-shared-jar]

elharo opened a new pull request, #149:
URL: https://github.com/apache/maven-shared-jar/pull/149

   Fixes apache/maven-shared-jar#140
   
   The UTF-8 constant pool filter in `ImportVisitor` (`VALID_UTF8_PATTERN`) rejected strings containing `$`, so inner class references like `org/apache/tools/ant/XmlLogger$TimedElement` were silently dropped from the discovered imports. Additionally, `QUALIFIED_IMPORT_PATTERN` did not allow `$`, causing raw descriptor strings (e.g. `L...$Inner;`) to leak in unparsed.
   
   Changes:
   - allow `$` in `VALID_UTF8_PATTERN`
   - allow `$` in the qualified-class portion of `QUALIFIED_IMPORT_PATTERN` so descriptors are still unwrapped correctly
   - add a regression test that compiles a class holding an inner-class reference in its UTF-8 pool and asserts it is collected as an import
   
   All 76 tests pass; checkstyle clean.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(classes): keep inner class references ($) from UTF-8 pool in ImportVisitor [maven-shared-jar]

Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo merged PR #149:
URL: https://github.com/apache/maven-shared-jar/pull/149


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org