You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Jonathan Gray (JIRA)" <ji...@apache.org> on 2011/01/05 16:38:45 UTC

[jira] Created: (HBASE-3415) When scanners have readers updated we should use original file selection algorithm rather than include all files

When scanners have readers updated we should use original file selection algorithm rather than include all files
----------------------------------------------------------------------------------------------------------------

                 Key: HBASE-3415
                 URL: https://issues.apache.org/jira/browse/HBASE-3415
             Project: HBase
          Issue Type: Bug
          Components: regionserver
    Affects Versions: 0.20.7, 0.90.0
            Reporter: Jonathan Gray
             Fix For: 0.90.1


Currently when a {{StoreScanner}} is instantiated we use a {{getScanner(scan, columns)}} call that looks at things like bloom filters and memstore only flags.  But when we get a changed readers notification, we use {{getScanner()}} which just grabs everything.

We should always use the original file selection algorithm.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (HBASE-3415) When scanners have readers updated we should use original file selection algorithm rather than include all files

Posted by "Jonathan Gray (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-3415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12977817#action_12977817 ] 

Jonathan Gray commented on HBASE-3415:
--------------------------------------

Yeah, now there's just getScanner() but the implementation of it is the old getScanner(scan, columns).  Instead of being passed to the method, they are stored as class variables.

> When scanners have readers updated we should use original file selection algorithm rather than include all files
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-3415
>                 URL: https://issues.apache.org/jira/browse/HBASE-3415
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.20.7, 0.90.0
>            Reporter: Jonathan Gray
>             Fix For: 0.90.1
>
>         Attachments: HBASE-3415-v1.patch
>
>
> Currently when a {{StoreScanner}} is instantiated we use a {{getScanner(scan, columns)}} call that looks at things like bloom filters and memstore only flags.  But when we get a changed readers notification, we use {{getScanner()}} which just grabs everything.
> We should always use the original file selection algorithm.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (HBASE-3415) When scanners have readers updated we should use original file selection algorithm rather than include all files

Posted by "stack (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-3415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12977815#action_12977815 ] 

stack commented on HBASE-3415:
------------------------------

Am I missing something?  You remove the getScanner(scan, columns) in the patch, the thing you would seem to want to preserve going by your comment above.

> When scanners have readers updated we should use original file selection algorithm rather than include all files
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-3415
>                 URL: https://issues.apache.org/jira/browse/HBASE-3415
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.20.7, 0.90.0
>            Reporter: Jonathan Gray
>             Fix For: 0.90.1
>
>         Attachments: HBASE-3415-v1.patch
>
>
> Currently when a {{StoreScanner}} is instantiated we use a {{getScanner(scan, columns)}} call that looks at things like bloom filters and memstore only flags.  But when we get a changed readers notification, we use {{getScanner()}} which just grabs everything.
> We should always use the original file selection algorithm.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (HBASE-3415) When scanners have readers updated we should use original file selection algorithm rather than include all files

Posted by "Jonathan Gray (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-3415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Gray updated HBASE-3415:
---------------------------------

    Attachment: HBASE-3415-v1.patch

First go.  There are other bugs in this code and updating readers, especially with intra-row scans.  Going to file more jiras.

> When scanners have readers updated we should use original file selection algorithm rather than include all files
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-3415
>                 URL: https://issues.apache.org/jira/browse/HBASE-3415
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.20.7, 0.90.0
>            Reporter: Jonathan Gray
>             Fix For: 0.90.1
>
>         Attachments: HBASE-3415-v1.patch
>
>
> Currently when a {{StoreScanner}} is instantiated we use a {{getScanner(scan, columns)}} call that looks at things like bloom filters and memstore only flags.  But when we get a changed readers notification, we use {{getScanner()}} which just grabs everything.
> We should always use the original file selection algorithm.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.