[GitHub] [superset] eschutho commented on a diff in pull request #23145: chore: refactor SparklineCell for react 17 and react 18 upgrade

["eschutho (via GitHub)" <gi...@apache.org>]

eschutho commented on code in PR #23145:
URL: https://github.com/apache/superset/pull/23145#discussion_r1116242419


##########
superset-frontend/package.json:
##########
@@ -114,7 +113,12 @@
     "@superset-ui/plugin-chart-word-cloud": "file:./plugins/plugin-chart-word-cloud",
     "@superset-ui/preset-chart-xy": "file:./plugins/preset-chart-xy",
     "@superset-ui/switchboard": "file:./packages/superset-ui-switchboard",
+    "@visx/axis": "^3.0.1",
+    "@visx/grid": "^3.0.1",

Review Comment:
   any reason for/against using the same version across all @vizx packages?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org