You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2022/02/01 05:51:40 UTC
[kudu-CR] Add test for coaslece and repartition
mkorad@twilio.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18185
Change subject: Add test for coaslece and repartition
......................................................................
Add test for coaslece and repartition
Change-Id: Ie80004755dc2e69acaccd51150559dbcd5fe0072
---
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackup.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/Options.scala
M java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
3 files changed, 19 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/85/18185/1
--
To view, visit http://gerrit.cloudera.org:8080/18185
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie80004755dc2e69acaccd51150559dbcd5fe0072
Gerrit-Change-Number: 18185
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <mk...@twilio.com>
[kudu-CR] Add test for coaslece and repartition
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
mkorad@twilio.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/18185 )
Change subject: Add test for coaslece and repartition
......................................................................
Patch Set 1:
> Patch Set 1:
>
> (1 comment)
>
> > Patch Set 1:
> >
> > > Uploaded patch set 1.
> >
> > Hi Attlia, I have addressed the comments.
> > I couldn't find the exact test failure in TestOptions in Jenkins build http://jenkins.kudu.apache.org/job/kudu-gerrit/25054/BUILD_TYPE=TSAN/console
> >
> > the build indicates no test failures,
> > Can you please point me to the exact failure message? Thanks!
>
> You'll see a dist-test link near the end of the console output for the Java build:
>
> http://dist-test.cloudera.org/job?job_id=jenkins-slave.1643694375.3513524
Thanks, fixed the test and spacing.
--
To view, visit http://gerrit.cloudera.org:8080/18185
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie80004755dc2e69acaccd51150559dbcd5fe0072
Gerrit-Change-Number: 18185
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <mk...@twilio.com>
Gerrit-Reviewer: Anonymous Coward <mk...@twilio.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 03 Feb 2022 23:55:11 +0000
Gerrit-HasComments: No
[kudu-CR] Add test for coaslece and repartition
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
mkorad@twilio.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/18185 )
Change subject: Add test for coaslece and repartition
......................................................................
Patch Set 1:
> Uploaded patch set 1.
Hi Attlia, I have addressed the comments.
I couldn't find the exact test failure in TestOptions in Jenkins build http://jenkins.kudu.apache.org/job/kudu-gerrit/25054/BUILD_TYPE=TSAN/console
the build indicates no test failures,
Can you please point me to the exact failure message? Thanks!
--
To view, visit http://gerrit.cloudera.org:8080/18185
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie80004755dc2e69acaccd51150559dbcd5fe0072
Gerrit-Change-Number: 18185
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <mk...@twilio.com>
Gerrit-Reviewer: Anonymous Coward <mk...@twilio.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 01 Feb 2022 06:03:33 +0000
Gerrit-HasComments: No
[kudu-CR] Add test for coaslece and repartition
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18185 )
Change subject: Add test for coaslece and repartition
......................................................................
Patch Set 1:
(1 comment)
> Patch Set 1:
>
> > Uploaded patch set 1.
>
> Hi Attlia, I have addressed the comments.
> I couldn't find the exact test failure in TestOptions in Jenkins build http://jenkins.kudu.apache.org/job/kudu-gerrit/25054/BUILD_TYPE=TSAN/console
>
> the build indicates no test failures,
> Can you please point me to the exact failure message? Thanks!
You'll see a dist-test link near the end of the console output for the Java build:
http://dist-test.cloudera.org/job?job_id=jenkins-slave.1643694375.3513524
http://gerrit.cloudera.org:8080/#/c/18185/1/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackup.scala
File java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackup.scala:
http://gerrit.cloudera.org:8080/#/c/18185/1/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackup.scala@93
PS1, Line 93: (
nit: space
--
To view, visit http://gerrit.cloudera.org:8080/18185
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie80004755dc2e69acaccd51150559dbcd5fe0072
Gerrit-Change-Number: 18185
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <mk...@twilio.com>
Gerrit-Reviewer: Anonymous Coward <mk...@twilio.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 01 Feb 2022 10:53:30 +0000
Gerrit-HasComments: Yes