You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Garrett Rooney <ro...@electricjellyfish.net> on 2006/10/17 21:15:44 UTC
Re: [PATCH] Improve mingw support
On 7/15/06, Paul Querna <ch...@force-elite.com> wrote:
> Improve the ability to compile under mingw32.
>
> * libsvn_subr/cmdline.c,
> include/svn_client.h,
> libsvn_subr/simple_providers.c,
> libsvn_client/compat_providers.c: Remove support for the windows
> specific CryptProtectData for authentication. Mingw doesn't include
> the definitions for this in their headers.
>
> * libsvn_subr/config_win.c: Define the minimum IE version to 5.0, since
> mingw32 doesn't seem to define this.
>
I committed a chunk of this (turning off the auth provider) in r22006,
if someone wants to actualy fix MinGW to make it unnecessary we can
revisit it in the future. The rest still needs more work done before
it can go in.
-garrett
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Improve mingw support
Posted by Matthias Miller <Bl...@OutOfHanwell.com>.
Garrett Rooney wrote:
> On 7/15/06, Paul Querna <ch...@force-elite.com> wrote:
>
>> Improve the ability to compile under mingw32.
>>
>> * libsvn_subr/cmdline.c,
>> include/svn_client.h,
>> libsvn_subr/simple_providers.c,
>> libsvn_client/compat_providers.c: Remove support for the windows
>> specific CryptProtectData for authentication. Mingw doesn't
>> include
>> the definitions for this in their headers.
>>
>> * libsvn_subr/config_win.c: Define the minimum IE version to 5.0, since
>> mingw32 doesn't seem to define this.
>>
>
> I committed a chunk of this (turning off the auth provider) in r22006,
> if someone wants to actualy fix MinGW to make it unnecessary we can
> revisit it in the future. The rest still needs more work done before
> it can go in.
>
> -garrett
A while back I posted a patch to MinGW
(http://sourceforge.net/tracker/index.php?func=detail&aid=1558980&group_id=2435&atid=302435)
before I realized that w32api is now hosted on Cygwin. I resubmitted a
patch but have gotten no response:
http://cygwin.com/ml/cygwin-patches/2006-q3/msg00075.html.
The rest of the changes require investigation of some MinGW build issues
with gettext/libintl. (Subversion isn't realizing that it's installed.)
I haven't had a chance to look into that.
Regards,
-Matthias Miller
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Improve mingw support
Posted by Branko Čibej <br...@xbc.nu>.
Garrett Rooney wrote:
> On 10/17/06, Branko Čibej <br...@xbc.nu> wrote:
>
>> That's ... *bad*
>>
>> It's more important to encrypt the passwords than to be able to compile
>> with MinGW, so -1.
>>
>> Instead, you could declare CopyProtectData in svn_private_config.hw
>> #ifdef __MINGW32__.
>
> It's actually not CopyProtectData that's the issue, it's
> CRYPTPROTECT_PROMPTSTRUCT and CRYPTPROTECT_UI_FORBIDDEN. I've got a
> diff here that inlines their declarations in simple_providers.c for
> MinGW, but is it's just based on some random stuff I found out on the
> web, I have no clue if it's correct. It seems to run, although I
> haven't tested it fully. I'm also kind of curious if this sort of
> thing is considered ok, do windows people really just inline defs to
> work around stuff like this?
Windows people have the Platform SDK installed. :)
Subversion people sometimes do that.
I haven't a clue about MinGW people ...
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Improve mingw support
Posted by Garrett Rooney <ro...@electricjellyfish.net>.
On 10/17/06, Branko Čibej <br...@xbc.nu> wrote:
> That's ... *bad*
>
> It's more important to encrypt the passwords than to be able to compile
> with MinGW, so -1.
>
> Instead, you could declare CopyProtectData in svn_private_config.hw
> #ifdef __MINGW32__.
It's actually not CopyProtectData that's the issue, it's
CRYPTPROTECT_PROMPTSTRUCT and CRYPTPROTECT_UI_FORBIDDEN. I've got a
diff here that inlines their declarations in simple_providers.c for
MinGW, but is it's just based on some random stuff I found out on the
web, I have no clue if it's correct. It seems to run, although I
haven't tested it fully. I'm also kind of curious if this sort of
thing is considered ok, do windows people really just inline defs to
work around stuff like this?
-garrett
Re: [PATCH] Improve mingw support
Posted by Branko Čibej <br...@xbc.nu>.
Garrett Rooney wrote:
> On 7/15/06, Paul Querna <ch...@force-elite.com> wrote:
>
>> Improve the ability to compile under mingw32.
>>
>> * libsvn_subr/cmdline.c,
>> include/svn_client.h,
>> libsvn_subr/simple_providers.c,
>> libsvn_client/compat_providers.c: Remove support for the windows
>> specific CryptProtectData for authentication. Mingw doesn't
>> include
>> the definitions for this in their headers.
>>
>> * libsvn_subr/config_win.c: Define the minimum IE version to 5.0, since
>> mingw32 doesn't seem to define this.
>>
>
> I committed a chunk of this (turning off the auth provider)
That's ... *bad*
It's more important to encrypt the passwords than to be able to compile
with MinGW, so -1.
Instead, you could declare CopyProtectData in svn_private_config.hw
#ifdef __MINGW32__.
-- Brane
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org