You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Brice Arnould (JIRA)" <ji...@apache.org> on 2008/05/13 10:14:55 UTC
[jira] Created: (HADOOP-3377) Use StringUtils#replaceAll instead of
Use StringUtils#replaceAll instead of
--------------------------------------
Key: HADOOP-3377
URL: https://issues.apache.org/jira/browse/HADOOP-3377
Project: Hadoop Core
Issue Type: Improvement
Components: mapred
Reporter: Brice Arnould
Priority: Trivial
A minor cleanup.
In the TaskRunner, we can read : "When hadoop moves to JDK1.5, replace [TaskRunner.replaceAll] with String#replace"
This patch do so, removing ~30 lines.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3377) Use StringUtils#replaceAll instead of
Posted by "Brice Arnould (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brice Arnould updated HADOOP-3377:
----------------------------------
Attachment: make_TaskRunner_use_stringReplace.patch
> Use StringUtils#replaceAll instead of
> --------------------------------------
>
> Key: HADOOP-3377
> URL: https://issues.apache.org/jira/browse/HADOOP-3377
> Project: Hadoop Core
> Issue Type: Improvement
> Components: mapred
> Reporter: Brice Arnould
> Priority: Trivial
> Attachments: make_TaskRunner_use_stringReplace.patch
>
>
> A minor cleanup.
> In the TaskRunner, we can read : "When hadoop moves to JDK1.5, replace [TaskRunner.replaceAll] with String#replace"
> This patch do so, removing ~30 lines.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3377) Use StringUtils#replaceAll instead
of
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12597460#action_12597460 ]
Hudson commented on HADOOP-3377:
--------------------------------
Integrated in Hadoop-trunk #493 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/493/])
> Use StringUtils#replaceAll instead of
> --------------------------------------
>
> Key: HADOOP-3377
> URL: https://issues.apache.org/jira/browse/HADOOP-3377
> Project: Hadoop Core
> Issue Type: Improvement
> Components: mapred
> Reporter: Brice Arnould
> Assignee: Brice Arnould
> Priority: Trivial
> Fix For: 0.18.0
>
> Attachments: make_TaskRunner_use_stringReplace.patch
>
>
> A minor cleanup.
> In the TaskRunner, we can read : "When hadoop moves to JDK1.5, replace [TaskRunner.replaceAll] with String#replace"
> This patch do so, removing ~30 lines.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3377) Use StringUtils#replaceAll instead of
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated HADOOP-3377:
----------------------------------
Resolution: Fixed
Fix Version/s: 0.18.0
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this. Thanks, Brice
> Use StringUtils#replaceAll instead of
> --------------------------------------
>
> Key: HADOOP-3377
> URL: https://issues.apache.org/jira/browse/HADOOP-3377
> Project: Hadoop Core
> Issue Type: Improvement
> Components: mapred
> Reporter: Brice Arnould
> Assignee: Brice Arnould
> Priority: Trivial
> Fix For: 0.18.0
>
> Attachments: make_TaskRunner_use_stringReplace.patch
>
>
> A minor cleanup.
> In the TaskRunner, we can read : "When hadoop moves to JDK1.5, replace [TaskRunner.replaceAll] with String#replace"
> This patch do so, removing ~30 lines.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3377) Use StringUtils#replaceAll instead of
Posted by "Brice Arnould (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brice Arnould updated HADOOP-3377:
----------------------------------
Assignee: Brice Arnould
Status: Patch Available (was: Open)
> Use StringUtils#replaceAll instead of
> --------------------------------------
>
> Key: HADOOP-3377
> URL: https://issues.apache.org/jira/browse/HADOOP-3377
> Project: Hadoop Core
> Issue Type: Improvement
> Components: mapred
> Reporter: Brice Arnould
> Assignee: Brice Arnould
> Priority: Trivial
> Attachments: make_TaskRunner_use_stringReplace.patch
>
>
> A minor cleanup.
> In the TaskRunner, we can read : "When hadoop moves to JDK1.5, replace [TaskRunner.replaceAll] with String#replace"
> This patch do so, removing ~30 lines.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3377) Use StringUtils#replaceAll instead
of
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12596342#action_12596342 ]
Hadoop QA commented on HADOOP-3377:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12381934/make_TaskRunner_use_stringReplace.patch
against trunk revision 655674.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2455/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2455/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2455/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2455/console
This message is automatically generated.
> Use StringUtils#replaceAll instead of
> --------------------------------------
>
> Key: HADOOP-3377
> URL: https://issues.apache.org/jira/browse/HADOOP-3377
> Project: Hadoop Core
> Issue Type: Improvement
> Components: mapred
> Reporter: Brice Arnould
> Assignee: Brice Arnould
> Priority: Trivial
> Attachments: make_TaskRunner_use_stringReplace.patch
>
>
> A minor cleanup.
> In the TaskRunner, we can read : "When hadoop moves to JDK1.5, replace [TaskRunner.replaceAll] with String#replace"
> This patch do so, removing ~30 lines.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.