You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kylin.apache.org by qh...@apache.org on 2015/07/27 11:21:20 UTC
[18/52] [abbrv] incubator-kylin git commit: KYLIN-875 Fix CI,
NPE in DictionaryManager.decideSourceData()
KYLIN-875 Fix CI, NPE in DictionaryManager.decideSourceData()
Project: http://git-wip-us.apache.org/repos/asf/incubator-kylin/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-kylin/commit/b02c963b
Tree: http://git-wip-us.apache.org/repos/asf/incubator-kylin/tree/b02c963b
Diff: http://git-wip-us.apache.org/repos/asf/incubator-kylin/diff/b02c963b
Branch: refs/heads/0.8
Commit: b02c963beb1f17d711cb64b8f5adc060e1bd2d5e
Parents: dd6ded6
Author: Li, Yang <ya...@ebay.com>
Authored: Thu Jul 23 14:48:43 2015 +0800
Committer: Li, Yang <ya...@ebay.com>
Committed: Thu Jul 23 14:48:43 2015 +0800
----------------------------------------------------------------------
.../java/org/apache/kylin/common/persistence/ResourceStore.java | 2 +-
.../src/main/java/org/apache/kylin/dict/DictionaryManager.java | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-kylin/blob/b02c963b/core-common/src/main/java/org/apache/kylin/common/persistence/ResourceStore.java
----------------------------------------------------------------------
diff --git a/core-common/src/main/java/org/apache/kylin/common/persistence/ResourceStore.java b/core-common/src/main/java/org/apache/kylin/common/persistence/ResourceStore.java
index 3bbcb0a..630477b 100644
--- a/core-common/src/main/java/org/apache/kylin/common/persistence/ResourceStore.java
+++ b/core-common/src/main/java/org/apache/kylin/common/persistence/ResourceStore.java
@@ -68,7 +68,7 @@ abstract public class ResourceStore {
try {
knownImpl.add(ClassUtil.forName("org.apache.kylin.storage.hbase.HBaseResourceStore", ResourceStore.class));
} catch (Throwable e) {
- logger.warn("Failed to load ResourceStore impl class", e);
+ logger.warn("Failed to load ResourceStore impl class: " + e.toString());
}
}
return knownImpl;
http://git-wip-us.apache.org/repos/asf/incubator-kylin/blob/b02c963b/core-dictionary/src/main/java/org/apache/kylin/dict/DictionaryManager.java
----------------------------------------------------------------------
diff --git a/core-dictionary/src/main/java/org/apache/kylin/dict/DictionaryManager.java b/core-dictionary/src/main/java/org/apache/kylin/dict/DictionaryManager.java
index a579abf..f7a407b 100644
--- a/core-dictionary/src/main/java/org/apache/kylin/dict/DictionaryManager.java
+++ b/core-dictionary/src/main/java/org/apache/kylin/dict/DictionaryManager.java
@@ -248,7 +248,7 @@ public class DictionaryManager {
srcCol = col.getName();
srcColIdx = col.getColumnDesc().getZeroBasedIndex();
if (model.isFactTable(col.getTable())) {
- table = factTableValueProvider.getDistinctValuesFor(col);
+ table = (factTableValueProvider == null) ? null : factTableValueProvider.getDistinctValuesFor(col);
} else {
table = TableSourceFactory.createReadableTable(metaMgr.getTableDesc(col.getTable()));
}