You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/04/23 04:12:05 UTC
[GitHub] [apisix] spacewander commented on a change in pull request #4116: fix(healthcheck): only one_loop is needed in the passive health check report
spacewander commented on a change in pull request #4116:
URL: https://github.com/apache/apisix/pull/4116#discussion_r618925530
##########
File path: apisix/init.lua
##########
@@ -615,13 +615,11 @@ local function healthcheck_passive(api_ctx)
end
for i, status in ipairs(http_statuses) do
- for i, status in ipairs(http_statuses) do
- if resp_status == status then
- checker:report_http_status(api_ctx.balancer_ip,
- port or api_ctx.balancer_port,
- host,
- resp_status)
- end
+ if resp_status == status then
+ checker:report_http_status(api_ctx.balancer_ip,
+ port or api_ctx.balancer_port,
Review comment:
Please keep the original indentation with space
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org