You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fury.apache.org by "LiangliangSui (via GitHub)" <gi...@apache.org> on 2024/04/03 06:49:03 UTC
Re: [PR] chore(java): Add comments for loop unrolling [incubator-fury]
LiangliangSui commented on code in PR #1450:
URL: https://github.com/apache/incubator-fury/pull/1450#discussion_r1549004814
##########
java/fury-core/src/main/java/org/apache/fury/memory/MemoryBuffer.java:
##########
@@ -1316,24 +1316,15 @@ public int readPositiveVarInt() {
}
private int readPositiveVarIntSlow() {
- int b = readByte();
- int result = b & 0x7F;
- if ((b & 0x80) != 0) {
+ int shift = 0;
Review Comment:
Updated.
BTW, do we need to add the benchmark code (sample code above) that uses loop and does not use loop in the `MemoryBuffer#readPositiveVarIntSlow` method to the benchmark directory?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org