You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@madlib.apache.org by njayaram2 <gi...@git.apache.org> on 2018/06/05 20:50:45 UTC

[GitHub] madlib pull request #275: Madpack: Fix error with dropping user after IC fai...

GitHub user njayaram2 opened a pull request:

    https://github.com/apache/madlib/pull/275

    Madpack: Fix error with dropping user after IC failure.

    JIRA: MADLIB-1182
    
    Previously, when install check did not fail gracefully, the user created
    by madpack hung around and disturbed IC attempts within other databases.
    We fixed this by:
    1) Renaming the test user using the specific database that the IC test
    was run from, making the test user name database-specific.
    2) Dropping schema and user in a try-finally block, so that it's executed even
    on a failed IC run.
    
    Co-authored-by: Arvind Sridhar <as...@pivotal.io>

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/madlib/madlib bugfix/madpack-ic-user

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/madlib/pull/275.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #275
    
----
commit d817973e78fa419dd7b83b077049c8c6b1911911
Author: Nandish Jayaram <nj...@...>
Date:   2018-06-05T19:08:25Z

    Madpack: Fix error with dropping user after IC failure.
    
    JIRA: MADLIB-1182
    
    Previously, when install check did not fail gracefully, the user created
    by madpack hung around and disturbed IC attempts within other databases.
    We fixed this by:
    1) Renaming the test user using the specific database that the IC test
    was run from, making the test user name database-specific.
    2) Dropping schema and user in a try-finally block, so that it's executed even
    on a failed IC run.
    
    Co-authored-by: Arvind Sridhar <as...@pivotal.io>

----


---

[GitHub] madlib pull request #275: Madpack: Fix error with dropping user after IC fai...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/madlib/pull/275


---

[GitHub] madlib issue #275: Madpack: Fix error with dropping user after IC failure.

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:

    https://github.com/apache/madlib/pull/275
  
    
    Refer to this link for build results (access rights to CI server needed): 
    https://builds.apache.org/job/madlib-pr-build/497/



---