You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "elharo (via GitHub)" <gi...@apache.org> on 2023/04/25 11:11:48 UTC

[GitHub] [maven-site-plugin] elharo opened a new pull request, #147: super trivial change to see if the CI is fixed

elharo opened a new pull request, #147:
URL: https://github.com/apache/maven-site-plugin/pull/147

       Oscar Wilde, among his various stories told here of which he was always the aesthetic hero, related that once while on a visit to an English country house he was much annoyed by the pronounced Philistinism of a certain fellow guest, who loudly stated that all artistic employment was a melancholy waste of time.
   
       “Well, Mr. Wilde,” said Oscar’s bugbear one day at lunch, “and pray how have you been passing your morning?” “Oh! I have been immensely busy,” said Oscar with great gravity. “I have spent my whole time over the proof sheets of my book of poems.” The Philistine with a growl inquired the result of that.
   
       “Well, it was very important,” said Oscar. “I took out a comma.” “Indeed,” returned the enemy of literature, “is that all you did?” Oscar, with a sweet smile, said, “By no means; on mature reflection I put back the comma.” This was too much for the Philistine, who took the next train to London.
   
   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
    - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MSITE) filed 
          for the change (usually before you start working on it).  Trivial changes like typos do not 
          require a JIRA issue.  Your pull request should address just this issue, without 
          pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line and body.
    - [ ] Format the pull request title like `[MSITE-XXX] - Fixes bug in ApproximateQuantiles`,
          where you replace `MSITE-XXX` with the appropriate JIRA issue. Best practice
          is to use the JIRA issue title in the pull request title and in the first line of the 
          commit message.
    - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will 
          be performed on your pull request automatically.
    - [ ] You have run the integration tests successfully (`mvn -Prun-its clean verify`).
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
    - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
    - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [maven-site-plugin] michael-o commented on pull request #147: super trivial change to see if the CI is fixed

Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #147:
URL: https://github.com/apache/maven-site-plugin/pull/147#issuecomment-1526246288

   This can be closed now...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [maven-site-plugin] michael-o closed pull request #147: super trivial change to see if the CI is fixed

Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o closed pull request #147: super trivial change to see if the CI is fixed
URL: https://github.com/apache/maven-site-plugin/pull/147


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [maven-site-plugin] elharo commented on pull request #147: super trivial change to see if the CI is fixed

Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on PR #147:
URL: https://github.com/apache/maven-site-plugin/pull/147#issuecomment-1521611528

   still broken:
   
   [INFO] ------------------------------------------------------------------------
   
   [ERROR] Failed to execute goal org.apache.maven.plugins:maven-site-plugin:3.12.1:site (default-site) on project maven-site-plugin: RendererException while preparing context for skin: Cannot use skin: has 2.0.0-M5 Doxia Sitetools prerequisite, but current is 1.11.1 -> [Help 1]
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org