You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Johan Huylebroeck <Jo...@realdolmen.com> on 2016/07/29 10:32:20 UTC
SCM-677
Hello,
I recently bumped into a known bug SCM-677 when using the scm plugin with subversion.
I think that a relatively easy, though svn specific, solution could be implemented by first adding all directories leading up to the file(s) before adding the file.
Suppose I want to add file A/B/c. The svnAddCommand could first do "svn add -depth=empty A A/B" and then "svn add A/B/c"
This may result in some (harmless) warning if the directories are already in svn but is relatively simple to implement.
Would you be willing to accept a patch that implements this?
Kind regards,
Johan
Re: SCM-677
Posted by Michael Osipov <mi...@apache.org>.
Am 2016-07-29 um 20:25 schrieb Johan Huylebroeck:
> Hello,
> I wasn't aware of this "--parent" option.
> That is indeed the simplest solution.
> Next 2 weeks I'm offline but after that I'll be happy to contribute to a patch.
Good. Prepare a patch, add appropriate unit tests and ping me in the
ticket. I will review and apply.
> -----Original Message-----
> From: Michael Osipov [mailto:michaelo@apache.org]
> Sent: vrijdag 29 juli 2016 12:57
> To: Maven Developers List <de...@maven.apache.org>
> Subject: Re: SCM-677
>
> Am 2016-07-29 um 12:32 schrieb Johan Huylebroeck:
>> Hello,
>> I recently bumped into a known bug SCM-677 when using the scm plugin with subversion.
>> I think that a relatively easy, though svn specific, solution could be implemented by first adding all directories leading up to the file(s) before adding the file.
>> Suppose I want to add file A/B/c. The svnAddCommand could first do "svn add -depth=empty A A/B" and then "svn add A/B/c"
>> This may result in some (harmless) warning if the directories are already in svn but is relatively simple to implement.
>> Would you be willing to accept a patch that implements this?
>
> This is actually weird. Have you checked the targets file?
> I have just replayed the issue without debugging it. I do assume that with A/ the directory is traversed and added to targets. --non-recursive is deprecated and your problem is that in A/ --parents is misisng.
>
> What about dropping --non-recursive and adding --parents instead? This is easy to fix and can be checked with A and a/
>
> WDYT?
>
> Michael
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org For additional commands, e-mail: dev-help@maven.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
RE: SCM-677
Posted by Johan Huylebroeck <Jo...@realdolmen.com>.
Hello,
I wasn't aware of this "--parent" option.
That is indeed the simplest solution.
Next 2 weeks I'm offline but after that I'll be happy to contribute to a patch.
Kind regards,
Johan
-----Original Message-----
From: Michael Osipov [mailto:michaelo@apache.org]
Sent: vrijdag 29 juli 2016 12:57
To: Maven Developers List <de...@maven.apache.org>
Subject: Re: SCM-677
Am 2016-07-29 um 12:32 schrieb Johan Huylebroeck:
> Hello,
> I recently bumped into a known bug SCM-677 when using the scm plugin with subversion.
> I think that a relatively easy, though svn specific, solution could be implemented by first adding all directories leading up to the file(s) before adding the file.
> Suppose I want to add file A/B/c. The svnAddCommand could first do "svn add -depth=empty A A/B" and then "svn add A/B/c"
> This may result in some (harmless) warning if the directories are already in svn but is relatively simple to implement.
> Would you be willing to accept a patch that implements this?
This is actually weird. Have you checked the targets file?
I have just replayed the issue without debugging it. I do assume that with A/ the directory is traversed and added to targets. --non-recursive is deprecated and your problem is that in A/ --parents is misisng.
What about dropping --non-recursive and adding --parents instead? This is easy to fix and can be checked with A and a/
WDYT?
Michael
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org For additional commands, e-mail: dev-help@maven.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: SCM-677
Posted by Michael Osipov <mi...@apache.org>.
Am 2016-07-29 um 12:32 schrieb Johan Huylebroeck:
> Hello,
> I recently bumped into a known bug SCM-677 when using the scm plugin with subversion.
> I think that a relatively easy, though svn specific, solution could be implemented by first adding all directories leading up to the file(s) before adding the file.
> Suppose I want to add file A/B/c. The svnAddCommand could first do "svn add -depth=empty A A/B" and then "svn add A/B/c"
> This may result in some (harmless) warning if the directories are already in svn but is relatively simple to implement.
> Would you be willing to accept a patch that implements this?
This is actually weird. Have you checked the targets file?
I have just replayed the issue without debugging it. I do assume that
with A/ the directory is traversed and added to targets. --non-recursive
is deprecated and your problem is that in A/ --parents is misisng.
What about dropping --non-recursive and adding --parents instead? This
is easy to fix and can be checked with A and a/
WDYT?
Michael
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org