You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by RebieKong <gi...@git.apache.org> on 2018/11/20 10:27:03 UTC

[GitHub] carbondata pull request #2934: [Documentation] Readme updated some error lin...

GitHub user RebieKong opened a pull request:

    https://github.com/apache/carbondata/pull/2934

    [Documentation] Readme updated some error links had been fixed

    Readme updated
    some error links that link to datamap had been link to correct file


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/RebieKong/carbondata RebieKong-README-UPDATE-2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2934.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2934
    
----
commit 3ddf15e8466c740f1177b02bb93802c6cefff790
Author: RebieKong <ma...@...>
Date:   2018-11-20T10:23:26Z

    [Documentation] Readme updated some error links had been fixed
    
    Readme updated
    some error links that link to datamap had been link to correct file

----


---

[GitHub] carbondata issue #2934: [CARBONDATA-3111] Readme updated some error links ha...

Posted by sraghunandan <gi...@git.apache.org>.
Github user sraghunandan commented on the issue:

    https://github.com/apache/carbondata/pull/2934
  
    LGTM


---

[GitHub] carbondata pull request #2934: [CARBONDATA-3111] Readme updated some error l...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2934


---

[GitHub] carbondata issue #2934: [CARBONDATA-3111] Readme updated some error links ha...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2934
  
    Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9739/



---

[GitHub] carbondata issue #2934: [CARBONDATA-3111] Readme updated some error links ha...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2934
  
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1691/



---

[GitHub] carbondata issue #2934: [Documentation] Readme updated some error links had ...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2934
  
    Can one of the admins verify this patch?


---

[GitHub] carbondata pull request #2934: [CARBONDATA-3111] Readme updated some error l...

Posted by sraghunandan <gi...@git.apache.org>.
Github user sraghunandan commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2934#discussion_r235255701
  
    --- Diff: README.md ---
    @@ -55,11 +55,11 @@ CarbonData is built using Apache Maven, to [build CarbonData](https://github.com
      * [Configuring CarbonData](https://github.com/apache/carbondata/blob/master/docs/configuration-parameters.md) 
      * [DataMap Developer Guide](https://github.com/apache/carbondata/blob/master/docs/datamap-developer-guide.md) 
      * [Data Types](https://github.com/apache/carbondata/blob/master/docs/supported-data-types-in-carbondata.md) 
    -* [CarbonData DataMap Management](https://github.com/apache/carbondata/blob/master/docs/datamap-management.md) 
    - * [CarbonData BloomFilter DataMap](https://github.com/apache/carbondata/blob/master/docs/bloomfilter-datamap-guide.md) 
    - * [CarbonData Lucene DataMap](https://github.com/apache/carbondata/blob/master/docs/lucene-datamap-guide.md) 
    - * [CarbonData Pre-aggregate DataMap](https://github.com/apache/carbondata/blob/master/docs/preaggregate-datamap-guide.md) 
    - * [CarbonData Timeseries DataMap](https://github.com/apache/carbondata/blob/master/docs/timeseries-datamap-guide.md) 
    +* [CarbonData DataMap Management](https://github.com/apache/carbondata/blob/master/docs/datamap/datamap-management.md) 
    + * [CarbonData BloomFilter DataMap](https://github.com/apache/carbondata/blob/master/docs/datamap/bloomfilter-datamap-guide.md) 
    + * [CarbonData Lucene DataMap](https://github.com/apache/carbondata/blob/master/docs/datamap/lucene-datamap-guide.md) 
    + * [CarbonData Pre-aggregate DataMap](https://github.com/apache/carbondata/blob/master/docs/datamap/preaggregate-datamap-guide.md)     
    --- End diff --
    
    Please remove the extra tab


---

[GitHub] carbondata pull request #2934: [CARBONDATA-3111] Readme updated some error l...

Posted by RebieKong <gi...@git.apache.org>.
Github user RebieKong commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2934#discussion_r235258034
  
    --- Diff: README.md ---
    @@ -55,11 +55,11 @@ CarbonData is built using Apache Maven, to [build CarbonData](https://github.com
      * [Configuring CarbonData](https://github.com/apache/carbondata/blob/master/docs/configuration-parameters.md) 
      * [DataMap Developer Guide](https://github.com/apache/carbondata/blob/master/docs/datamap-developer-guide.md) 
      * [Data Types](https://github.com/apache/carbondata/blob/master/docs/supported-data-types-in-carbondata.md) 
    -* [CarbonData DataMap Management](https://github.com/apache/carbondata/blob/master/docs/datamap-management.md) 
    - * [CarbonData BloomFilter DataMap](https://github.com/apache/carbondata/blob/master/docs/bloomfilter-datamap-guide.md) 
    - * [CarbonData Lucene DataMap](https://github.com/apache/carbondata/blob/master/docs/lucene-datamap-guide.md) 
    - * [CarbonData Pre-aggregate DataMap](https://github.com/apache/carbondata/blob/master/docs/preaggregate-datamap-guide.md) 
    - * [CarbonData Timeseries DataMap](https://github.com/apache/carbondata/blob/master/docs/timeseries-datamap-guide.md) 
    +* [CarbonData DataMap Management](https://github.com/apache/carbondata/blob/master/docs/datamap/datamap-management.md) 
    + * [CarbonData BloomFilter DataMap](https://github.com/apache/carbondata/blob/master/docs/datamap/bloomfilter-datamap-guide.md) 
    + * [CarbonData Lucene DataMap](https://github.com/apache/carbondata/blob/master/docs/datamap/lucene-datamap-guide.md) 
    + * [CarbonData Pre-aggregate DataMap](https://github.com/apache/carbondata/blob/master/docs/datamap/preaggregate-datamap-guide.md)     
    --- End diff --
    
    ok~


---

[GitHub] carbondata issue #2934: [CARBONDATA-3111] Readme updated some error links ha...

Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/2934
  
    LGTM


---

[GitHub] carbondata issue #2934: [Documentation] Readme updated some error links had ...

Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/2934
  
    @RebieKong Can you raise a JIRA for it? and then add JIRA number in title.  such as:[CARBONDATA-2999] support read schema from S3
    
    and please keep :
    `Any interfaces changed?
    
      Any backward compatibility impacted?
    
      Document update required?
    
      Testing done
    
      For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    `



---

[GitHub] carbondata issue #2934: [CARBONDATA-3111] Readme updated some error links ha...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2934
  
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1481/



---

[GitHub] carbondata issue #2934: [CARBONDATA-3111] Readme updated some error links ha...

Posted by RebieKong <gi...@git.apache.org>.
Github user RebieKong commented on the issue:

    https://github.com/apache/carbondata/pull/2934
  
    if it is good now?


---

[GitHub] carbondata issue #2934: [CARBONDATA-3111] Readme updated some error links ha...

Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 commented on the issue:

    https://github.com/apache/carbondata/pull/2934
  
    add to whitelist


---

[GitHub] carbondata issue #2934: [CARBONDATA-3111] Readme updated some error links ha...

Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 commented on the issue:

    https://github.com/apache/carbondata/pull/2934
  
    LGTM


---