You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/09/01 12:30:16 UTC
[GitHub] [incubator-devlake] e2corporation opened a new issue, #2915: [Bug][Config-UI] Refactor PR 2887 causing duplicate PATCH+POST for Save/Modify
e2corporation opened a new issue, #2915:
URL: https://github.com/apache/incubator-devlake/issues/2915
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/incubator-devlake/issues?q=is%3Aissue) and found no similar issues.
### What happened
The Refactor PR https://github.com/apache/incubator-devlake/pull/2887 has introduced a new bug where connections are modified and save twice. Please see comments starting on `Ln 260`.
### What you expected to happen
`saveConfiguration` and `modifyConfiguration` should not be triggered twice. Either the original flow needs to be reverted, or only the new `savePromise` should be executed.
### How to reproduce
Save or Modify any connection and Check XHR Log. 2 `PATCH` and 2 `POST` requests are dispatched.
### Anything else
_No response_
### Version
main
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] likyh commented on issue #2915: [Bug][Config-UI] Refactor PR 2887 causing duplicate PATCH+POST for Save/Modify
Posted by GitBox <gi...@apache.org>.
likyh commented on issue #2915:
URL: https://github.com/apache/incubator-devlake/issues/2915#issuecomment-1234224574
> @likyh Nice, did you test and check XHR log to verify that only 1 event gets dispatched?
@e2corporation No, promise.then and setTimeout will both run but they have the different conditions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] e2corporation closed issue #2915: [Bug][Config-UI] Refactor PR 2887 causing duplicate PATCH+POST for Save/Modify
Posted by GitBox <gi...@apache.org>.
e2corporation closed issue #2915: [Bug][Config-UI] Refactor PR 2887 causing duplicate PATCH+POST for Save/Modify
URL: https://github.com/apache/incubator-devlake/issues/2915
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] e2corporation commented on issue #2915: [Bug][Config-UI] Refactor PR 2887 causing duplicate PATCH+POST for Save/Modify
Posted by GitBox <gi...@apache.org>.
e2corporation commented on issue #2915:
URL: https://github.com/apache/incubator-devlake/issues/2915#issuecomment-1234219739
@likyh Nice, did you test and check XHR log to verify that only 1 event gets dispatched?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] e2corporation commented on issue #2915: [Bug][Config-UI] Refactor PR 2887 causing duplicate PATCH+POST for Save/Modify
Posted by GitBox <gi...@apache.org>.
e2corporation commented on issue #2915:
URL: https://github.com/apache/incubator-devlake/issues/2915#issuecomment-1234214699
@likyh Can you take a look and resolve accordingly? The easiest fix would be to comment out the extra calls to modify and save.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] likyh commented on issue #2915: [Bug][Config-UI] Refactor PR 2887 causing duplicate PATCH+POST for Save/Modify
Posted by GitBox <gi...@apache.org>.
likyh commented on issue #2915:
URL: https://github.com/apache/incubator-devlake/issues/2915#issuecomment-1234215360
ok, rebase bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] e2corporation commented on issue #2915: [Bug][Config-UI] Refactor PR 2887 causing duplicate PATCH+POST for Save/Modify
Posted by GitBox <gi...@apache.org>.
e2corporation commented on issue #2915:
URL: https://github.com/apache/incubator-devlake/issues/2915#issuecomment-1234226315
The POSTing/PATCHing has nothing to do with the timeout, I mean to confirm when you hit save on a New connection, only 1 POST request is sent. Likewise with Modify. This timeout should be replaced with an Effect instead, to monitor the saveComplete prop.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org