You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/04/19 16:15:22 UTC
[GitHub] [superset] cemremengu opened a new pull request, #19779: feat: make CTA text in Alerts & Reports mails configurable
cemremengu opened a new pull request, #19779:
URL: https://github.com/apache/superset/pull/19779
### SUMMARY
This PR makes call-to-action link text used in Alerts & Reports emails configurable
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #19779: feat: make CTA text in Alerts & Reports mails configurable
Posted by GitBox <gi...@apache.org>.
rusackas commented on PR #19779:
URL: https://github.com/apache/superset/pull/19779#issuecomment-1374241993
Closing/reopening to kick-start CI. Sorry this fell between the couch cushions for so long! Please feel free to nag us more here or on Slack if this happens again! Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas closed pull request #19779: feat: make CTA text in Alerts & Reports mails configurable
Posted by GitBox <gi...@apache.org>.
rusackas closed pull request #19779: feat: make CTA text in Alerts & Reports mails configurable
URL: https://github.com/apache/superset/pull/19779
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #19779: feat: make CTA text in Alerts & Reports mails configurable
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #19779:
URL: https://github.com/apache/superset/pull/19779#issuecomment-1374247139
# [Codecov](https://codecov.io/gh/apache/superset/pull/19779?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19779](https://codecov.io/gh/apache/superset/pull/19779?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b04eaab) into [master](https://codecov.io/gh/apache/superset/commit/34008f78c9456bd40c0893dd8e239b5c47b612e4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (34008f7) will **decrease** coverage by `10.75%`.
> The diff coverage is `n/a`.
> :exclamation: Current head b04eaab differs from pull request most recent head e68b86b. Consider uploading reports for the commit e68b86b to get more accurate results
```diff
@@ Coverage Diff @@
## master #19779 +/- ##
===========================================
- Coverage 66.51% 55.75% -10.76%
===========================================
Files 1686 1859 +173
Lines 64589 71036 +6447
Branches 6635 7766 +1131
===========================================
- Hits 42959 39605 -3354
- Misses 19931 29409 +9478
- Partials 1699 2022 +323
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `52.38% <ø> (-0.17%)` | :arrow_down: |
| python | `57.81% <ø> (-24.62%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `51.47% <ø> (+3.71%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19779?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...-ui-chart-controls/src/components/MetricOption.tsx](https://codecov.io/gh/apache/superset/pull/19779?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLnRzeA==) | `90.90% <ø> (-3.83%)` | :arrow_down: |
| [...et-ui-chart-controls/src/components/labelUtils.tsx](https://codecov.io/gh/apache/superset/pull/19779?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvbGFiZWxVdGlscy50c3g=) | `100.00% <ø> (ø)` | |
| [...ckages/superset-ui-chart-controls/src/constants.ts](https://codecov.io/gh/apache/superset/pull/19779?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbnN0YW50cy50cw==) | `100.00% <ø> (ø)` | |
| [...ackages/superset-ui-chart-controls/src/fixtures.ts](https://codecov.io/gh/apache/superset/pull/19779?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2ZpeHR1cmVzLnRz) | `100.00% <ø> (ø)` | |
| [...d/packages/superset-ui-chart-controls/src/index.ts](https://codecov.io/gh/apache/superset/pull/19779?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2luZGV4LnRz) | `100.00% <ø> (ø)` | |
| [...art-controls/src/operators/contributionOperator.ts](https://codecov.io/gh/apache/superset/pull/19779?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL29wZXJhdG9ycy9jb250cmlidXRpb25PcGVyYXRvci50cw==) | `100.00% <ø> (ø)` | |
| [...ui-chart-controls/src/operators/flattenOperator.ts](https://codecov.io/gh/apache/superset/pull/19779?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL29wZXJhdG9ycy9mbGF0dGVuT3BlcmF0b3IudHM=) | `100.00% <ø> (ø)` | |
| [...t-ui-chart-controls/src/operators/pivotOperator.ts](https://codecov.io/gh/apache/superset/pull/19779?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL29wZXJhdG9ycy9waXZvdE9wZXJhdG9yLnRz) | `100.00% <ø> (ø)` | |
| [...ui-chart-controls/src/operators/prophetOperator.ts](https://codecov.io/gh/apache/superset/pull/19779?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL29wZXJhdG9ycy9wcm9waGV0T3BlcmF0b3IudHM=) | `100.00% <ø> (ø)` | |
| [...-ui-chart-controls/src/operators/renameOperator.ts](https://codecov.io/gh/apache/superset/pull/19779?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL29wZXJhdG9ycy9yZW5hbWVPcGVyYXRvci50cw==) | `100.00% <ø> (ø)` | |
| ... and [1153 more](https://codecov.io/gh/apache/superset/pull/19779?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] cemremengu commented on pull request #19779: feat: make CTA text in Alerts & Reports mails configurable
Posted by GitBox <gi...@apache.org>.
cemremengu commented on PR #19779:
URL: https://github.com/apache/superset/pull/19779#issuecomment-1374507194
@rusackas no worries, repo is busy like a bee hive already so don't want to ping much. Thanks for your hardwork!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] cemremengu commented on pull request #19779: feat: make CTA text in Alerts & Reports mails configurable
Posted by GitBox <gi...@apache.org>.
cemremengu commented on PR #19779:
URL: https://github.com/apache/superset/pull/19779#issuecomment-1374507297
@rusackas no worries, repo is busy like a bee hive already so don't want to ping much. Thanks for your hardwork!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas merged pull request #19779: feat: make CTA text in Alerts & Reports mails configurable
Posted by GitBox <gi...@apache.org>.
rusackas merged PR #19779:
URL: https://github.com/apache/superset/pull/19779
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org