You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/05/04 18:41:36 UTC
[GitHub] [pinot] jtao15 opened a new pull request, #8639: Allow rerunning startReplaceSegment with the same segmentsTo if the revious protocol fails in the middle (lineage entry in IN_PROGRESS status).
jtao15 opened a new pull request, #8639:
URL: https://github.com/apache/pinot/pull/8639
This pr enhance current startReplaceSegment api to cover the following case:
Initial state:
```
lineageEntry1: { segmentsFrom: [], segmentsTo: [s1, s2], status: IN_PROGRESS}
```
Restart the protocol with the same segmentsTo will go through and revert lineageEntry1:
```
lineageEntry1: { segmentsFrom: [], segmentsTo: [s1, s2], status: REVERTED}
lineageEntry2: { segmentsFrom: [], segmentsTo: [s1, s2], status: IN_PROGRESS}
```
Note:
The segment deletion in startReplaceSegment api is async, the client side should wait till the clean up is finished before uploading the new segments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] snleee merged pull request #8639: Allow rerunning startReplaceSegment with the same segmentsTo if the revious protocol fails in the middle (lineage entry in IN_PROGRESS status).
Posted by GitBox <gi...@apache.org>.
snleee merged PR #8639:
URL: https://github.com/apache/pinot/pull/8639
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter commented on pull request #8639: Allow rerunning startReplaceSegment with the same segmentsTo if the revious protocol fails in the middle (lineage entry in IN_PROGRESS status).
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #8639:
URL: https://github.com/apache/pinot/pull/8639#issuecomment-1117720932
# [Codecov](https://codecov.io/gh/apache/pinot/pull/8639?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#8639](https://codecov.io/gh/apache/pinot/pull/8639?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (763e104) into [master](https://codecov.io/gh/apache/pinot/commit/9873ed9b967b25b64b94492df1490797a768fc2c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9873ed9) will **decrease** coverage by `3.00%`.
> The diff coverage is `85.09%`.
```diff
@@ Coverage Diff @@
## master #8639 +/- ##
============================================
- Coverage 69.46% 66.45% -3.01%
+ Complexity 4411 4328 -83
============================================
Files 1669 1261 -408
Lines 87387 63837 -23550
Branches 13092 9919 -3173
============================================
- Hits 60700 42423 -18277
+ Misses 22450 18404 -4046
+ Partials 4237 3010 -1227
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1 | `?` | |
| unittests1 | `66.45% <85.09%> (+0.05%)` | :arrow_up: |
| unittests2 | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pinot/pull/8639?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ion/function/FirstWithTimeAggregationFunction.java](https://codecov.io/gh/apache/pinot/pull/8639/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9mdW5jdGlvbi9GaXJzdFdpdGhUaW1lQWdncmVnYXRpb25GdW5jdGlvbi5qYXZh) | `49.27% <49.27%> (ø)` | |
| [...gregation/function/AggregationFunctionFactory.java](https://codecov.io/gh/apache/pinot/pull/8639/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9mdW5jdGlvbi9BZ2dyZWdhdGlvbkZ1bmN0aW9uRmFjdG9yeS5qYXZh) | `80.91% <60.00%> (-2.71%)` | :arrow_down: |
| [...n/FirstDoubleValueWithTimeAggregationFunction.java](https://codecov.io/gh/apache/pinot/pull/8639/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9mdW5jdGlvbi9GaXJzdERvdWJsZVZhbHVlV2l0aFRpbWVBZ2dyZWdhdGlvbkZ1bmN0aW9uLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...on/FirstFloatValueWithTimeAggregationFunction.java](https://codecov.io/gh/apache/pinot/pull/8639/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9mdW5jdGlvbi9GaXJzdEZsb2F0VmFsdWVXaXRoVGltZUFnZ3JlZ2F0aW9uRnVuY3Rpb24uamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...tion/FirstIntValueWithTimeAggregationFunction.java](https://codecov.io/gh/apache/pinot/pull/8639/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9mdW5jdGlvbi9GaXJzdEludFZhbHVlV2l0aFRpbWVBZ2dyZWdhdGlvbkZ1bmN0aW9uLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...ion/FirstLongValueWithTimeAggregationFunction.java](https://codecov.io/gh/apache/pinot/pull/8639/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9mdW5jdGlvbi9GaXJzdExvbmdWYWx1ZVdpdGhUaW1lQWdncmVnYXRpb25GdW5jdGlvbi5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...n/FirstStringValueWithTimeAggregationFunction.java](https://codecov.io/gh/apache/pinot/pull/8639/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9mdW5jdGlvbi9GaXJzdFN0cmluZ1ZhbHVlV2l0aFRpbWVBZ2dyZWdhdGlvbkZ1bmN0aW9uLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...che/pinot/segment/spi/AggregationFunctionType.java](https://codecov.io/gh/apache/pinot/pull/8639/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc2VnbWVudC1zcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3NlZ21lbnQvc3BpL0FnZ3JlZ2F0aW9uRnVuY3Rpb25UeXBlLmphdmE=) | `89.41% <100.00%> (+0.12%)` | :arrow_up: |
| [...va/org/apache/pinot/core/routing/RoutingTable.java](https://codecov.io/gh/apache/pinot/pull/8639/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yb3V0aW5nL1JvdXRpbmdUYWJsZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...va/org/apache/pinot/common/config/NettyConfig.java](https://codecov.io/gh/apache/pinot/pull/8639/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vY29uZmlnL05ldHR5Q29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [616 more](https://codecov.io/gh/apache/pinot/pull/8639/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/pinot/pull/8639?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/pinot/pull/8639?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b317246...763e104](https://codecov.io/gh/apache/pinot/pull/8639?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org