You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/09/29 13:37:39 UTC
[GitHub] [incubator-nuttx] raiden00pl opened a new pull request #1915: nrf52: add serial termios support
raiden00pl opened a new pull request #1915:
URL: https://github.com/apache/incubator-nuttx/pull/1915
## Summary
Add serial termios support for NRF52.
Flow control not supported yet.
## Impact
## Testing
Termios operations on a custom nrf52840 board
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] raiden00pl commented on a change in pull request #1915: nrf52: add serial termios support
Posted by GitBox <gi...@apache.org>.
raiden00pl commented on a change in pull request #1915:
URL: https://github.com/apache/incubator-nuttx/pull/1915#discussion_r496786825
##########
File path: arch/arm/src/nrf52/nrf52_serial.c
##########
@@ -432,7 +454,118 @@ static int nrf52_interrupt(int irq, void *context, FAR void *arg)
static int nrf52_ioctl(struct file *filep, int cmd, unsigned long arg)
{
- return -ENOTTY;
+ struct inode *inode = filep->f_inode;
+ struct uart_dev_s *dev = inode->i_private;
+ struct nrf52_dev_s *priv = (struct nrf52_dev_s *)dev->priv;
+ struct uart_config_s *config = &priv->config;
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis merged pull request #1915: nrf52: add serial termios support
Posted by GitBox <gi...@apache.org>.
acassis merged pull request #1915:
URL: https://github.com/apache/incubator-nuttx/pull/1915
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on a change in pull request #1915: nrf52: add serial termios support
Posted by GitBox <gi...@apache.org>.
acassis commented on a change in pull request #1915:
URL: https://github.com/apache/incubator-nuttx/pull/1915#discussion_r496760751
##########
File path: arch/arm/src/nrf52/nrf52_serial.c
##########
@@ -432,7 +454,118 @@ static int nrf52_interrupt(int irq, void *context, FAR void *arg)
static int nrf52_ioctl(struct file *filep, int cmd, unsigned long arg)
{
- return -ENOTTY;
+ struct inode *inode = filep->f_inode;
+ struct uart_dev_s *dev = inode->i_private;
+ struct nrf52_dev_s *priv = (struct nrf52_dev_s *)dev->priv;
+ struct uart_config_s *config = &priv->config;
Review comment:
The error is on this config variable, maybe add an UNUSED(config) at end of the ioctl() or put the definition inside the #ifdef ...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org