[GitHub] vanzin commented on issue #23504: [SPARK-26585][K8S] Add additional integration tests for K8s Scheduler Backend

[GitBox <gi...@apache.org>]

vanzin commented on issue #23504: [SPARK-26585][K8S] Add additional integration tests for K8s Scheduler Backend
URL: https://github.com/apache/spark/pull/23504#issuecomment-453277057
 
 
   I'm a little skeptical of these tests. What benefit do they bring on top of a unit test that checks that these properties are set in the pod descriptor sent to the k8s server?
   
   And even in the case that there is a tangible benefit, why do they need to be separate tests? Why not set these properties in an existing test? Integration tests are expensive to run, adding a bunch of small tests to check specific things means you're wasting 20-40s to test a single config property.
   
   (The latter, btw, also applies to a bunch of existing tests...)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org