Re: [PR] [CALCITE-7795] SemanticTable FilterRequirement is dropped by certain query shapes [calcite]

["liuyongvs (via GitHub)" <gi...@apache.org>]

liuyongvs commented on PR #5275:
URL: https://github.com/apache/calcite/pull/5275#issuecomment-6188595062

   退订
   
   Ruben Quesada Lopez ***@***.***> 于2026年9月21日周一 17:54写道：
   
   > ***@***.**** commented on this pull request.
   > ------------------------------
   >
   > In
   > core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java
   > <https://github.com/apache/calcite/pull/5275#discussion_r4060997184>:
   >
   > > @@ -4719,12 +4748,11 @@ private static void purgeForBypassFields(SqlNode node, SqlValidatorScope scope,
   >                    .collect(Collectors.toList());
   >            sameIdentifier.forEach(qualifieds::remove);
   >
   > -          // Clear all the remnant must-filter qualifieds from the same table identifier
   > -          Collection<SqlQualified> sameIdentifier_ =
   > -              remnantMustFilterFields.stream()
   > -                  .filter(q -> qualifiedMatchesIdentifier(q, qualified))
   > -                  .collect(Collectors.toList());
   > -          sameIdentifier_.forEach(remnantMustFilterFields::remove);
   > +          // Clear the remnant must-filter qualifieds imported through the
   > +          // same FROM item (namespace) as the filtered bypass field
   > +          if (qualified.namespace != null) {
   >
   > Not sure I understand, could you please provide an example?
   >
   > —
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/calcite/pull/5275?email_source=notifications&email_token=ABQGFUMKDG6X5SKLBETKY2D5QD3GHA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTKMRWGUZDENRZGM42M4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSWGM33PORSXEX3DNRUWG2Y#discussion_r4060997184>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/ABQGFUOISMLCL7YGU4HKU535QD3GHAVCNFSNUABEKJSXA33TNF2G64TZHMZDCMJZGM2TENB3JFZXG5LFHM2TKMBSHA4TEMJWGOQXMAQ>
   > .
   > Triage notifications, keep track of coding agent tasks and review pull
   > requests on the go with GitHub Mobile for iOS
   > <https://github.com/notifications/mobile/ios/ABQGFUPVHQHKIRA62HHVAMT5QD3GHA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTKMRWGUZDENRZGM42M4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSVGM33PORSXEX3JN5ZQ>
   > and Android
   > <https://github.com/notifications/mobile/android/ABQGFUMQWP7U26CVYCIGXHL5QD3GHA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTKMRWGUZDENRZGM42M4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSXGM33PORSXEX3BNZSHE33JMQ>.
   > Download it today!
   > You are receiving this because you are subscribed to this thread.Message
   > ID: <apache/calcite/pull/5275/review/5265226939 ***@***.***
   > com>
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org